Re: [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable

James Bottomley
2009-07-16T14:43:19Z

On Thu, 2009-07-16 at 15:38 +0100, Matthew Garrett wrote:
> On Thu, Jul 16, 2009 at 04:30:13PM +0200, Stefan Richter wrote:
> > Matthew Garrett wrote:
> > > @@ -447,6 +448,11 @@ struct scsi_host_template {
> > > unsigned ordered_tag:1;
> > >
> > > /*
> > > + * True if host supports hotplugging
> > > + */
> > > + unsigned hotpluggable:1;
> > > +
> >
> > The comment should specify what the actual effects of the flag are.
> >
> > (Provides the default for Scsi_Host.hotpluggable?)
>
> Ok.
>
> > >
> > > + /* 1 if hotpluggable, 0 if not */
> > > + unsigned hotpluggable:1;
> > > +
> >
> > Ditto here.
>
> There's no in-kernel effect of this flag - it's just exposed to
> userspace.
>
> > (Is used by power management infrastructure to decide over runtime PM
> > policy? I.e. don't enter power states which would prevent the port from
> > detecting/ reporting hotplug events?)
>
> Exactly.

OK, so if this is only in relation to SATA power management, put it in
libata and call it something like pm_capable. That way we don't have to
work out what to do with it for the rest of SCSI.

James