Re: [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable

Matthew Garrett
2009-07-16T14:44:41Z

On Thu, Jul 16, 2009 at 04:36:14PM +0200, Stefan Richter wrote:
> Stefan Richter wrote:
> > The comment should specify what the actual effects of the flag are.
> [...]
> > (Is used by power management infrastructure to decide over runtime PM
> > policy? I.e. don't enter power states which would prevent the port from
> > detecting/ reporting hotplug events?)
>
> Perhaps the flag should be called differently (keep_ports_powered or
> whatever) --- unless you have additional future uses of the flag in mind
> which justify the more generic name.

Mm. I was actually wondering about that. For instance, laptop bays are
hotpluggable but provide notification out of band and so can use ALPM
without losing functionality. I'm not sure about "keep_ports_powered",
but I'll try to think of something better.

--
Matthew Garrett | mjg59@srcf.ucam.org