Re: [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable

Matthew Garrett
2009-07-16T14:38:28Z

On Thu, Jul 16, 2009 at 04:30:13PM +0200, Stefan Richter wrote:
> Matthew Garrett wrote:
> > @@ -447,6 +448,11 @@ struct scsi_host_template {
> > unsigned ordered_tag:1;
> >
> > /*
> > + * True if host supports hotplugging
> > + */
> > + unsigned hotpluggable:1;
> > +
>
> The comment should specify what the actual effects of the flag are.
>
> (Provides the default for Scsi_Host.hotpluggable?)

Ok.

> >
> > + /* 1 if hotpluggable, 0 if not */
> > + unsigned hotpluggable:1;
> > +
>
> Ditto here.

There's no in-kernel effect of this flag - it's just exposed to
userspace.

> (Is used by power management infrastructure to decide over runtime PM
> policy? I.e. don't enter power states which would prevent the port from
> detecting/ reporting hotplug events?)

Exactly.

--
Matthew Garrett | mjg59@srcf.ucam.org