public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Patterson <andrew.patterson@hp.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, linux-scsi@vger.kernel.org,
	mike.miller@hp.com, jens.axboe@oracle.com
Subject: [PATCH 2 0/4] cciss rmmod/scan-thread fixes
Date: Tue, 21 Jul 2009 13:55:17 -0600	[thread overview]
Message-ID: <20090721195517.20740.18994.stgit@bob.kio> (raw)

The following series fixes several problems causing hangs while
rmmoding the cciss driver. In the process of fixing these hangs, I
also reworked the the logical drive scanning kernel thread to use one
thread per driver rather than one thread per controller. I also added
a sysfs attribute to kick off a controller scan.

Changelog

v2

Staticially initialize scan_mutex and scan_q.
Remove unneeded function declarations.
Added a patch that uses a mutex to indicate we are busy initializing
rather than a integer flag.
Remove a possible scan race by moving the busy_initializing unlock after
the call to rebuild_luntable in cciss_init_one.
Reworked the scan thread to use a more traditional loop with a
set_current_state(TASK_INTERRUPTIBLE); schedule() at the top of the
loop.

 .../ABI/testing/sysfs-bus-pci-devices-cciss        |    7 +
 drivers/block/cciss.c                              |  204 +++++++++++++++++---
 drivers/block/cciss.h                              |    9 +
 3 files changed, 191 insertions(+), 29 deletions(-)

Andrew Patterson (4):
      cciss: remove logical drive sysfs entries during driver cleanup.
      cciss: use mutex instead of flag to indicate busy initializing
      cciss: use only one scan thread
      cciss: kick off logical drive topology rescan through sysfs



-- 
Andrew Patterson

             reply	other threads:[~2009-07-21 19:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21 19:55 Andrew Patterson [this message]
2009-07-21 19:55 ` [PATCH 2 1/4] cciss: remove logical drive sysfs entries during driver cleanup Andrew Patterson
2009-07-21 19:55 ` [PATCH 2 2/4] cciss: use mutex instead of flag to indicate busy initializing Andrew Patterson
2009-07-24  0:32   ` Andrew Morton
2009-07-21 19:55 ` [PATCH 2 3/4] cciss: use only one scan thread Andrew Patterson
2009-07-21 19:55 ` [PATCH 2 4/4] cciss: kick off logical drive topology rescan through sysfs Andrew Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090721195517.20740.18994.stgit@bob.kio \
    --to=andrew.patterson@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox