Re: Bugs in scsi_vpd_inquiry()

James Bottomley
2009-08-11T16:24:51Z

On Tue, 2009-08-11 at 12:14 -0400, Alan Stern wrote:
> On Tue, 11 Aug 2009, James Bottomley wrote:
>
> > Sort of, but it's not really doing it properly. Lets do it like this.
> > This should also fix the > 255 length problem older devices might have.
>
> Do you mind including also the residue check?

But there's no point to it ... it's a Byzantine check. The standard
says shall return as many bytes as will fit in the allocation length
(what it does with allocation length beyond data to return is
undefined).

For the USB case where a full residue and no error indicates there was
actually an error, we already have a translation.

If devices just return random data lengths and then stop, your proposed
residue check doesn't catch them anyway. However, I'd much rather
assume a device performs to spec until proven otherwise.

James