From: Christoph Hellwig <hch@infradead.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: akataria@vmware.com, James Bottomley <James.Bottomley@suse.de>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Brian King <brking@linux.vnet.ibm.com>,
"Chetan.Loke@Emulex.Com" <Chetan.Loke@Emulex.Com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.
Date: Wed, 9 Sep 2009 19:08:54 -0400 [thread overview]
Message-ID: <20090909230854.GA4495@infradead.org> (raw)
In-Reply-To: <4AA8284A.3010908@codemonkey.ws>
On Wed, Sep 09, 2009 at 05:12:26PM -0500, Anthony Liguori wrote:
> Alok Kataria wrote:
>> I see your point, but the ring logic or the ABI that we use to
>> communicate between the hypervisor and guest is not shared between our
>> storage and network drivers. As a result, I don't see any benefit of
>> separating out this ring handling mechanism, on the contrary it might
>> just add some overhead of translating between various layers for our
>> SCSI driver.
>>
>
> But if you separate out the ring logic, it allows the scsi logic to be
> shared by other paravirtual device drivers. This is significant and
> important from a Linux point of view.
As someone who has been hacking on a virtio scsi prototype I don't think
it's a good idea. The vmware driver is a horrible design and I don't
think it should be merged. Besides beeing a ugly driver and ABI we
really should not support this kind of closed protocol development.
next prev parent reply other threads:[~2009-09-09 23:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 1:15 [PATCH] SCSI driver for VMware's virtual HBA - V4 Alok Kataria
2009-09-09 1:26 ` Daniel Walker
2009-09-09 5:01 ` Alok Kataria
2009-09-09 5:54 ` Rolf Eike Beer
2009-09-09 16:56 ` Alok Kataria
2009-09-29 17:05 ` [Pv-drivers] " Alok Kataria
2009-09-09 21:00 ` Anthony Liguori
2009-09-09 21:51 ` Alok Kataria
2009-09-09 22:12 ` Anthony Liguori
2009-09-09 23:08 ` Christoph Hellwig [this message]
2009-09-09 23:34 ` Anthony Liguori
2009-09-09 23:54 ` Jeremy Fitzhardinge
2009-09-10 0:11 ` Anthony Liguori
2009-09-10 23:43 ` Alok Kataria
2009-09-10 23:43 ` Alok Kataria
2009-09-14 3:05 ` [Pv-drivers] " Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909230854.GA4495@infradead.org \
--to=hch@infradead.org \
--cc=Chetan.Loke@Emulex.Com \
--cc=James.Bottomley@suse.de \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=anthony@codemonkey.ws \
--cc=brking@linux.vnet.ibm.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox