From: "Michael S. Tsirkin" <mst@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Boaz Harrosh <bharrosh@panasas.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCHv2 1/4] scsi: consistent use of __u8 in scsi/scsi.h
Date: Tue, 29 Sep 2009 12:34:07 +0200 [thread overview]
Message-ID: <20090929103407.GB11183@redhat.com> (raw)
In-Reply-To: <cover.1254220284.git.mst@redhat.com>
scsi/scsi.h is exported to userspace, so it should
use __u8 instead of u8 as other userspace-visible headers do.
This fixes the following errors when application includes scsi/scsi.h
generated with make headers_install:
include/scsi/scsi.h:145: error: expected specifier-qualifier-list before ‘u8’
include/scsi/scsi.h: In function ‘scsi_varlen_cdb_length’:
include/scsi/scsi.h:156: error: ‘struct scsi_varlen_cdb_hdr’ has no member named ‘additional_cdb_length’
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/scsi/scsi.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index 084478e..dfcfaab 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -142,10 +142,10 @@ struct scsi_cmnd;
/* defined in T10 SCSI Primary Commands-2 (SPC2) */
struct scsi_varlen_cdb_hdr {
- u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
- u8 control;
- u8 misc[5];
- u8 additional_cdb_length; /* total cdb length - 8 */
+ __u8 opcode; /* opcode always == VARIABLE_LENGTH_CMD */
+ __u8 control;
+ __u8 misc[5];
+ __u8 additional_cdb_length; /* total cdb length - 8 */
__be16 service_action;
/* service specific data follows */
};
--
1.6.5.rc2
next parent reply other threads:[~2009-09-29 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1254220284.git.mst@redhat.com>
2009-09-29 10:34 ` Michael S. Tsirkin [this message]
2009-09-29 10:34 ` [PATCHv2 2/4] scsi: make scsi/scsi.h headers_check clean Michael S. Tsirkin
2009-09-29 10:34 ` [PATCHv2 3/4] scsi: export scsi_ioctl.h and sg.h headers Michael S. Tsirkin
2009-09-29 10:34 ` [PATCHv2 4/4] scsi: export scsi_tgt_if.h Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090929103407.GB11183@redhat.com \
--to=mst@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).