From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: [PATCHv2 1/4] scsi: consistent use of __u8 in scsi/scsi.h Date: Tue, 29 Sep 2009 12:34:07 +0200 Message-ID: <20090929103407.GB11183@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Boaz Harrosh , Sam Ravnborg List-Id: linux-scsi@vger.kernel.org scsi/scsi.h is exported to userspace, so it should use __u8 instead of u8 as other userspace-visible headers do. This fixes the following errors when application includes scsi/scsi.h generated with make headers_install: include/scsi/scsi.h:145: error: expected specifier-qualifier-list befor= e =E2=80=98u8=E2=80=99 include/scsi/scsi.h: In function =E2=80=98scsi_varlen_cdb_length=E2=80=99= : include/scsi/scsi.h:156: error: =E2=80=98struct scsi_varlen_cdb_hdr=E2=80= =99 has no member named =E2=80=98additional_cdb_length=E2=80=99 Signed-off-by: Michael S. Tsirkin --- include/scsi/scsi.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 084478e..dfcfaab 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -142,10 +142,10 @@ struct scsi_cmnd; =20 /* defined in T10 SCSI Primary Commands-2 (SPC2) */ struct scsi_varlen_cdb_hdr { - u8 opcode; /* opcode always =3D=3D VARIABLE_LENGTH_CMD */ - u8 control; - u8 misc[5]; - u8 additional_cdb_length; /* total cdb length - 8 */ + __u8 opcode; /* opcode always =3D=3D VARIABLE_LENGTH_CMD */ + __u8 control; + __u8 misc[5]; + __u8 additional_cdb_length; /* total cdb length - 8 */ __be16 service_action; /* service specific data follows */ }; --=20 1.6.5.rc2