From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
Christof Schmitt <christof.schmitt@de.ibm.com>
Subject: [patch 4/5] zfcp: Fix timer initialization for ct and els requests
Date: Tue, 13 Oct 2009 10:44:10 +0200 [thread overview]
Message-ID: <20091013084946.045644000@de.ibm.com> (raw)
In-Reply-To: 20091013084406.630890000@de.ibm.com
[-- Attachment #1: 715-zfcp-timer-init.diff --]
[-- Type: text/plain, Size: 808 bytes --]
From: Christof Schmitt <christof.schmitt@de.ibm.com>
Add HZ since the start_timer function expects jiffies, not seconds.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
---
drivers/s390/scsi/zfcp_fsf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/s390/scsi/zfcp_fsf.c 2009-10-12 09:56:27.000000000 +0200
+++ b/drivers/s390/scsi/zfcp_fsf.c 2009-10-12 09:56:31.000000000 +0200
@@ -1079,7 +1079,7 @@ static int zfcp_fsf_setup_ct_els(struct
/* common settings for ct/gs and els requests */
req->qtcb->bottom.support.service_class = FSF_CLASS_3;
req->qtcb->bottom.support.timeout = 2 * R_A_TOV;
- zfcp_fsf_start_timer(req, 2 * R_A_TOV + 10);
+ zfcp_fsf_start_timer(req, (2 * R_A_TOV + 10) * HZ);
return 0;
}
next prev parent reply other threads:[~2009-10-13 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 8:44 [patch 0/5] zfcp fixes for 2.6.32-rc4 Christof Schmitt
2009-10-13 8:44 ` [patch 1/5] zfcp: fix kfree handling in zfcp_init_device_setup Christof Schmitt
2009-10-13 8:44 ` [patch 2/5] zfcp: Handle WWPN mismatch in PLOGI payload Christof Schmitt
2009-10-13 16:51 ` Joe Eykholt
2009-10-13 18:09 ` James Smart
2009-10-14 8:42 ` Christof Schmitt
2009-10-14 9:00 ` [updated patch (fix comment)][patch " Christof Schmitt
2009-10-13 8:44 ` [patch 3/5] zfcp: Warn about storage devices with broken PLOGI data Christof Schmitt
2009-10-13 8:44 ` Christof Schmitt [this message]
2009-10-13 8:44 ` [patch 5/5] zfcp: Flush SCSI registration work when adding unit Christof Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013084946.045644000@de.ibm.com \
--to=christof.schmitt@de.ibm.com \
--cc=James.Bottomley@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).