From: Andrew Morton <akpm@linux-foundation.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma()
Date: Tue, 13 Oct 2009 16:40:17 -0700 [thread overview]
Message-ID: <20091013164017.f666d9a2.akpm@linux-foundation.org> (raw)
In-Reply-To: <4ACBA5E7.3090000@gmail.com>
On Tue, 06 Oct 2009 22:17:43 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Besides keeping the line short, the second setting of the
> MR_DMA_MODE bit was removed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Please review, maybe some other bit should be set?
The only ones left are MR_BLOCK_DMA_MODE and MR_ARBITRATE.
No, I don't know if they hould have been set either. Let that sleeping
dog lie, I suspect.
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index f92da9f..5d2f148 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1857,7 +1857,9 @@ static int NCR5380_transfer_dma(struct Scsi_Host *instance, unsigned char *phase
> #endif
> /* KLL May need eop and parity in 53c400 */
> if (hostdata->flags & FLAG_NCR53C400)
> - NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE | MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR | MR_ENABLE_EOP_INTR | MR_DMA_MODE | MR_MONITOR_BSY);
> + NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE |
> + MR_ENABLE_PAR_CHECK | MR_ENABLE_PAR_INTR |
> + MR_ENABLE_EOP_INTR | MR_MONITOR_BSY);
> else
> NCR5380_write(MODE_REG, MR_BASE | MR_DMA_MODE);
> #endif /* def REAL_DMA */
prev parent reply other threads:[~2009-10-13 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 20:17 [PATCH] NCR5380: bit MR_DMA_MODE set twice in NCR5380_transfer_dma() Roel Kluin
2009-10-13 23:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013164017.f666d9a2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).