From: Jens Axboe <jens.axboe@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, mkp@mkp.net, matthew@wil.cx
Subject: Re: [PATCH 1/2] block: add support for discard limits
Date: Mon, 2 Nov 2009 13:39:36 +0100 [thread overview]
Message-ID: <20091102123936.GV10727@kernel.dk> (raw)
In-Reply-To: <20091030050333.GB17714@infradead.org>
On Fri, Oct 30 2009, Christoph Hellwig wrote:
> On Thu, Oct 29, 2009 at 08:06:59PM +0100, Jens Axboe wrote:
> > On Thu, Oct 29 2009, Christoph Hellwig wrote:
> > > To properly support discard on SCSI Arrays we need to take the discard
> > > granularity and the first aligned discard LBA into account. This patch
> > > adds block limits for both of them, and trims down dicard requests to fit
> > > into these limits in blkdev_issue_discard. We also make sure the alignment
> > > offset is properly adjust for partitions and add sysfs files to expose
> > > the limits to userspaced.
> >
> > Except for a few typos, this looks good to me. I'll add it for 2.6.33.
>
> It would be good if we could queue up this (or mkp's version) with the
> sd bits through the scsi tree - otherwise getting testing for the whole
> stack will be a pain.
Sure, fine with me. Feel free to add my acked-by.
--
Jens Axboe
next prev parent reply other threads:[~2009-11-02 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 15:08 [PATCH 0/2] scsi discard support Christoph Hellwig
2009-10-29 15:08 ` [PATCH 1/2] block: add support for discard limits Christoph Hellwig
2009-10-29 19:06 ` Jens Axboe
2009-10-30 5:03 ` Christoph Hellwig
2009-11-02 12:39 ` Jens Axboe [this message]
2009-10-30 3:19 ` Martin K. Petersen
2009-10-30 5:05 ` Christoph Hellwig
2009-11-02 13:29 ` Martin K. Petersen
2009-11-02 15:39 ` James Bottomley
2009-11-02 18:16 ` Martin K. Petersen
2009-11-02 16:02 ` Boaz Harrosh
2009-11-02 18:18 ` Martin K. Petersen
2009-11-03 15:16 ` Christoph Hellwig
2009-10-29 15:08 ` [PATCH 2/2] sd: add support for WRITE SAME (16) with unmap bit Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102123936.GV10727@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mkp@mkp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox