From: David Miller <davem@davemloft.net>
To: James.Bottomley@suse.de
Cc: roel.kluin@gmail.com, linux-scsi@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qlogicpti: add missing parentheses
Date: Tue, 03 Nov 2009 16:19:06 -0800 (PST) [thread overview]
Message-ID: <20091103.161906.261075602.davem@davemloft.net> (raw)
In-Reply-To: <1257292309.2454.54.camel@mulgrave.site>
From: James Bottomley <James.Bottomley@suse.de>
Date: Tue, 03 Nov 2009 17:51:49 -0600
> On Wed, 2009-11-04 at 00:38 +0100, Roel Kluin wrote:
>> `+' has a higher precedence than `?' so the condition always
>> evaluates to true and this is preprocessed to `7*((ql) - 1)'
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> drivers/scsi/qlogicpti.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> This one must be right, I think.
>
> It looks plausible ... but it will increase the mailbox segment length
> by 4 ... someone needs to verify that this increase will actually work
> and won't run off the end of the mailbox table.
It should be fine, good find Roel.
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-11-04 0:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 23:38 [PATCH] qlogicpti: add missing parentheses Roel Kluin
2009-11-03 23:51 ` James Bottomley
2009-11-04 0:19 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-18 12:48 [PATCH] qlogicpti: Add " Roel Kluin
2009-02-18 22:39 ` David Miller
2009-02-19 21:01 ` Andrew Morton
2009-02-20 8:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103.161906.261075602.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox