public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: jack_wang <jack_wang@usish.com>
To: "James Bottomley" <James.Bottomley@suse.de>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	"'Srinivas Naga Venkatasatya Pasagadugula'"
	<satyasrinivasp@hcl.in>, "'Tom Peng'" <tom_peng@usish.com>,
	"'andy yan'" <andyysj@gmail.com>, aoqingyun <aoqingyun@usish.com>
Subject: Re: Re: [PATCH] libsas: do not set res = 0 in sas_ex_discover_dev()
Date: Sat, 7 Nov 2009 06:36:53 +0800	[thread overview]
Message-ID: <200911070636527812488@usish.com> (raw)
In-Reply-To: 1257534748.2715.265.camel@mulgrave.site

OK, this one never actually made it to the list.  I think this was
because all the patches contained text/html attachments which the list
kills sight unseen because it thinks they're spam.  You really have to
make sure you only send text plain and patch attachments for them to get
through.

For simplicity, the patch is below for list review.

James
 [Jack] Sorry for that, We will make sure text/html things will never happen in the future. 
And thanks for you help.
---

From: jack wang <jack_wang@usish.com>
Subject: [PATCH] libsas: do not set res = 0 in sas_ex_discover_dev()

We should not set res to 0 in function sas_ex_discover_dev  in order to let
it discover it further when wide port hotplug in .

Signed-off-by: Tom Peng <tom_peng@usish.com>
Signed-off-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 drivers/scsi/libsas/sas_expander.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index b338195..33cf988 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -960,7 +960,6 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
 
 			}
 		}
-		res = 0;
 	}
 
 	return res;
-- 
1.6.4.2




      reply	other threads:[~2009-11-06 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 11:44 LIBSAS:Issue with cascading of edge expanders Srinivas Naga Venkatasatya Pasagadugula
     [not found] ` <e938503f0910181843q1569ca1eo34b3af884cefb45e@mail.gmail.com>
     [not found]   ` <63412251C6BA4D16B1721701D56292B8@usish.com.cn>
     [not found]     ` <6B62480106F2B34D8404CF2FDAA4D9EF38546AA598@CHN-HCLT-EVS06.HCLT.CORP.HCL.IN>
     [not found]       ` <9363F2E7DE9C4DBAB057D40324240F96@usish.com.cn>
2009-11-06 19:12         ` [PATCH] libsas: do not set res = 0 in sas_ex_discover_dev() James Bottomley
2009-11-06 22:36           ` jack_wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911070636527812488@usish.com \
    --to=jack_wang@usish.com \
    --cc=James.Bottomley@suse.de \
    --cc=andyysj@gmail.com \
    --cc=aoqingyun@usish.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=satyasrinivasp@hcl.in \
    --cc=tom_peng@usish.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox