public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: hch@infradead.org, axboe@kernel.dk, matthew@wil.cx,
	linux-scsi@vger.kernel.org
Subject: Re: Thin provisioning update
Date: Mon, 9 Nov 2009 09:20:51 -0500	[thread overview]
Message-ID: <20091109142051.GC4855@infradead.org> (raw)
In-Reply-To: <1257308740-4729-1-git-send-email-martin.petersen@oracle.com>

On Tue, Nov 03, 2009 at 11:25:38PM -0500, Martin K. Petersen wrote:
> Christoph,
> 
> Here are some more recent bits for you to tinker with.
> 
> The first patch exports unmap granularity and alignment up the stack.  I have
> also implemented support for topology stacking of these parameters.  A reported
> discard granularity of 0 means fully provisioned.
> 
> In the second patch I made a few changes to the TP detection and extraction of
> VPD values.

I was offline for a while, but I have another half-finished alternative
to it.  Which only exposes the discard granularity/alignment at the
whole disk level and does the adjustment in sd.  I think I actually
prefer it - I'll post it for review as soon as I have cought up with my
backlog.

> I have been hunting for heuristics for the WRITE SAME case but haven't found any
> good ones.  I'm thinking we probably want to distinguish between a real array
> with NV-backed unmap queueing and a thinly provisioned disk on a virtualization
> server where there might be a real impact from having to zero out partial blocks.
> I guess that's easy to handle with virtio but I'm not so sure how to do it when
> emulating a SCSI disk.

We might just offer UNMAP for virtualized disks for now to sort this
out.  But the primary use case at least for now will be ide TRIM for
virtualized environments with virtio as a second and scsi a distant
third for now.


  parent reply	other threads:[~2009-11-09 14:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04  4:25 Thin provisioning update Martin K. Petersen
2009-11-04  4:25 ` [PATCH 1/2] block: Expose discard granularity Martin K. Petersen
2009-11-04  4:25 ` [PATCH 2/2] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-11-09 14:20 ` Christoph Hellwig [this message]
2009-11-09 19:34   ` Thin provisioning update Christoph Hellwig
2009-11-10  5:37     ` Martin K. Petersen
2009-11-10 10:51       ` Jens Axboe
2009-11-10 13:16       ` Christoph Hellwig
2009-11-10 18:58         ` Martin K. Petersen
2009-11-10 19:10           ` James Bottomley
2009-11-10 23:06             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091109142051.GC4855@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox