Re: [PATCH 2/7]MVSAS:add supporting MSI feature

James Bottomley
2009-11-14T18:19:19Z

On Mon, 2009-11-09 at 20:08 +0800, Andy Yan wrote:
> From 8b51aa63e8b123046a334d630ae045f479acbf6c Mon Sep 17 00:00:00 2001
> From: andy <ayan@marvell.com>
> Date: Fri, 6 Nov 2009 17:03:21 +0800
> Subject: [PATCH 2/7] Add supporting MSI feature
>
> MSI feature is implemented with mvsas driver.
>
> Signed-off-by: Andy <ayan@marvell.com>
> Signed-off-by: Jacky <jfeng@marvell.com>
> Signed-off-by: Ke <kewei@marvell.com>

This doesn't compile:

CC [M] drivers/scsi/mvsas/mv_init.o
drivers/scsi/mvsas/mv_init.c: In function ‘mvs_enable_msi’:
drivers/scsi/mvsas/mv_init.c:197: error: ‘PCR_CMD’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c:197: error: (Each undeclared identifier is reported only once
drivers/scsi/mvsas/mv_init.c:197: error: for each function it appears in.)
drivers/scsi/mvsas/mv_init.c:201: error: ‘PCR_MSI_CTRL’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c: In function ‘mvs_disable_msi’:
drivers/scsi/mvsas/mv_init.c:208: error: ‘PCR_CMD’ undeclared (first use in this function)
drivers/scsi/mvsas/mv_init.c:212: error: ‘PCR_MSI_CTRL’ undeclared (first use in this function)

It looks like these definitions are added in patch 3 (after this
one) ... you can't do that: a patch series has to be bisectable

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html