[patch] potential null deref in lpfc_els.c

Dan Carpenter
2009-12-05T12:36:06Z

This patch is against 2.6.32-rc8.

The issue was found by a static checker. If cmd == ELS_CMD_PLOGI, it
is possible for ndlp to be NULL. We do check ndlp further down the
function so that would also indicate that we should check ndlp here.

Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/scsi/lpfc/lpfc_els.c 2009-12-05 10:52:02.000000000 +0200
+++ devel/drivers/scsi/lpfc/lpfc_els.c 2009-12-05 11:43:49.000000000 +0200
@@ -2548,7 +2548,7 @@ lpfc_els_retry(struct lpfc_hba *phba, st

lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD,
"Retry ELS: wd7:x%x wd4:x%x did:x%x",
- *(((uint32_t *) irsp) + 7), irsp->un.ulpWord[4], ndlp->nlp_DID);
+ *(((uint32_t *) irsp) + 7), irsp->un.ulpWord[4], (ndlp ? ndlp->nlp_DID : 0));

switch (irsp->ulpStatus) {