mvsas:Issues with write and erase of SATA DVD ROM

mvsas:Issues with write and erase of SATA DVD ROM

[Srinivas Naga Venkatasatya Pasagadugula - ERS, HCL Tech]

Hi,
I am facing an issue with write and erase of SATA DVD ROM.

HW DETAILS:
-----------
linux-sles: # cat /proc/scsi/scsi
Attached devices:
Host: scsi9 Channel: 00 Id: 01 Lun: 00
  Vendor: TSSTcorp Model: CDDVDW SH-S203D Rev: SB00
  Type:   CD-ROM ANSI SCSI revision: 05

Linux-sles: ~ # cdrecord --scanbus
scsibus9:
        9, 0, 0 900) 'TSSTcorp' 'CDDVDW SH-S203D ' 'SB00' Removable CD-ROM

ANALYSIS for erase Issue:
-------------------------
Linux-sles11:~ # cdrecord --dev=x,x,x -blank all
Timeout happened after issuing the above operation to target and LLD is initiating Abort-TMF.
Here is my analysis and solution for the same.
If we issue "blank command" to CDROM, the processing of that request will take some time to complete, mean while my timer has expired and issuing abort-task TMF.  So to avoid this situation set IMMED bit 1 in "blank command" then send to it target.
Reference from mmc4:
6.2.2.2 IMMED
If IMMED is zero, then the requested operation is processed to completion prior to returning status. If
IMMED is one, then status is returned once the operation has begun.

FIX:
....
mv_sas.c:
static int mvs_task_prep_ata(struct asc_info *asi,
       struct asc_task_exec_info *tei)
{       ...
        if (dev->sata_dev.command_set == ATAPI_COMMAND_SET) {
        ...
            if (task->ata_task.atapi_packet[0] == 0xa1) {/*a1 blank command */
                        task->ata_task.atapi_packet[1] = 0x10;
                }
      ...}
}
ANALYSIS for write issue:
-------------------------
linux-sles11:~ # cdrecord --dev=x,x,x -dao *.iso
After issuing above operation to target, receiving "reserved error" from target for one of the write command.
Dmesg:
------
mv_task_prep_ata:719:task[f52da6c0] cdb0[2a]:cdb1[0]:cdb2[0]
mv_slot_complete:2007:task[f52da6c0] rx_desc[30000]
mvsas:asc_slot_err:1845:err_dw0[80400002]
mv_sas.c 1883:find reserved error, why?
sas: command 0xf5e40bc0, task 0xf5934d00, timed out: BLK_EH_NOT_HANDLED

Here is the error location:
mv_sas.c:
static int asc_slot_err(struct asc_info *asi, struct sas_task *task,
                         u32 slot_idx)
{       ...
        if (err_dw0 == 0x80400002) {
                mv_printk("find reserved error, why?\n");
      }...
}
I don't know why we are receiving "reserved error" and how to respond to this error?
Any inputs are highly appreciated.

Thanks
Srinivas.


DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------

The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. 
It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in 
this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates. 
Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of 
this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have 
received this email in error please delete it and notify the sender immediately. Before opening any mail and 
attachments please check them for viruses and defect.

-----------------------------------------------------------------------------------------------------------------------

mvsas:Issues with write and erase of SATA DVD ROM

[Srinivas Naga Venkatasatya Pasagadugula - ERS, HCL Tech]

Hi all,

Could you please provide me some inputs on below issues?

--Srini.

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Srinivas Naga Venkatasatya Pasagadugula - ERS, HCL Tech
Sent: Friday, December 11, 2009 8:28 PM
To: linux-scsi@vger.kernel.org; ayan@marvell.com; kewei@marvell.com
Subject: mvsas:Issues with write and erase of SATA DVD ROM

Hi,
I am facing an issue with write and erase of SATA DVD ROM.

HW DETAILS:
-----------
linux-sles: # cat /proc/scsi/scsi
Attached devices:
Host: scsi9 Channel: 00 Id: 01 Lun: 00
  Vendor: TSSTcorp Model: CDDVDW SH-S203D Rev: SB00
  Type:   CD-ROM ANSI SCSI revision: 05

Linux-sles: ~ # cdrecord --scanbus
scsibus9:
        9, 0, 0 900) 'TSSTcorp' 'CDDVDW SH-S203D ' 'SB00' Removable CD-ROM

ANALYSIS for erase Issue:
-------------------------
Linux-sles11:~ # cdrecord --dev=x,x,x -blank all
Timeout happened after issuing the above operation to target and LLD is initiating Abort-TMF.
Here is my analysis and solution for the same.
If we issue "blank command" to CDROM, the processing of that request will take some time to complete, mean while my timer has expired and issuing abort-task TMF.  So to avoid this situation set IMMED bit 1 in "blank command" then send to it target.
Reference from mmc4:
6.2.2.2 IMMED
If IMMED is zero, then the requested operation is processed to completion prior to returning status. If
IMMED is one, then status is returned once the operation has begun.

FIX:
....
mv_sas.c:
static int mvs_task_prep_ata(struct asc_info *asi,
       struct asc_task_exec_info *tei)
{       ...
        if (dev->sata_dev.command_set == ATAPI_COMMAND_SET) {
        ...
            if (task->ata_task.atapi_packet[0] == 0xa1) {/*a1 blank command */
                        task->ata_task.atapi_packet[1] = 0x10;
                }
      ...}
}
ANALYSIS for write issue:
-------------------------
linux-sles11:~ # cdrecord --dev=x,x,x -dao *.iso
After issuing above operation to target, receiving "reserved error" from target for one of the write command.
Dmesg:
------
mv_task_prep_ata:719:task[f52da6c0] cdb0[2a]:cdb1[0]:cdb2[0]
mv_slot_complete:2007:task[f52da6c0] rx_desc[30000]
mvsas:asc_slot_err:1845:err_dw0[80400002]
mv_sas.c 1883:find reserved error, why?
sas: command 0xf5e40bc0, task 0xf5934d00, timed out: BLK_EH_NOT_HANDLED

Here is the error location:
mv_sas.c:
static int asc_slot_err(struct asc_info *asi, struct sas_task *task,
                         u32 slot_idx)
{       ...
        if (err_dw0 == 0x80400002) {
                mv_printk("find reserved error, why?\n");
      }...
}
I don't know why we are receiving "reserved error" and how to respond to this error?
Any inputs are highly appreciated.

Thanks
Srinivas.


DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------

The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. 
It shall not attach any liability on the originator or HCL or its affiliates. Any views or opinions presented in 
this email are solely those of the author and may not necessarily reflect the opinions of HCL or its affiliates. 
Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of 
this message without the prior written consent of the author of this e-mail is strictly prohibited. If you have 
received this email in error please delete it and notify the sender immediately. Before opening any mail and 
attachments please check them for viruses and defect.

-----------------------------------------------------------------------------------------------------------------------

Re: mvsas:Issues with write and erase of SATA DVD ROM

[Matthew Wilcox]

On Tue, Dec 15, 2009 at 07:32:53PM +0530, Srinivas Naga Venkatasatya Pasagadugula - ERS, HCL Tech wrote:
> ANALYSIS for erase Issue:
> -------------------------
> Linux-sles11:~ # cdrecord --dev=x,x,x -blank all
> Timeout happened after issuing the above operation to target and LLD is initiating Abort-TMF.
> Here is my analysis and solution for the same.
> If we issue "blank command" to CDROM, the processing of that request will take some time to complete, mean while my timer has expired and issuing abort-task TMF.  So to avoid this situation set IMMED bit 1 in "blank command" then send to it target.

That's a terrible solution.  cdrecord should be setting the timeout
for the command to a high (or even infinite) value.  Maybe it is, in
which case, you need to find out why the timer is expiring too soon.
More investigation needed to find out why the timer expires so soon
rather than this horrible hack.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."