public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Krishna Gudipati <kgudipat@brocade.com>
Cc: James.Bottomley@suse.de, linux-scsi@vger.kernel.org,
	adapter_linux_open_src_team@brocade.com, huangj@brocade.com,
	xmzhang@brocade.com
Subject: Re: [PATCH 1/2] bfa: Files to support BFA debugfs node creation, node query and node deletion.
Date: Tue, 12 Jan 2010 03:52:28 -0500	[thread overview]
Message-ID: <20100112085228.GA21015@infradead.org> (raw)
In-Reply-To: <1263254172-18675-1-git-send-email-kgudipat@blc-10-2.brocade.com>

Please add documentation for each file what it's useful for and how
users can use it.  And some files should not be there at all - e.g. the
trace file - please use the standard kernel tracing infrastructure
instead.

And to be frank - as long as the driver is such a fucking mess as it is
right now adding any additional features should be postponed until that
is sorted out.


      reply	other threads:[~2010-01-12  8:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 23:56 [PATCH 1/2] bfa: Files to support BFA debugfs node creation, node query and node deletion Krishna Gudipati
2010-01-12  8:52 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100112085228.GA21015@infradead.org \
    --to=hch@infradead.org \
    --cc=James.Bottomley@suse.de \
    --cc=adapter_linux_open_src_team@brocade.com \
    --cc=huangj@brocade.com \
    --cc=kgudipat@brocade.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=xmzhang@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox