From: Anatolij Gustschin <agust@denx.de>
To: linux-scsi@vger.kernel.org
Cc: Kashyap Desai <kashyap.desai@lsi.com>,
Eric Moore <Eric.Moore@lsi.com>,
James Bottomley <James.Bottomley@suse.de>
Subject: Re: [PATCH] [SCSI] mptsas: Fix issue with chain pools allocation on katmai
Date: Wed, 13 Jan 2010 11:13:13 +0100 [thread overview]
Message-ID: <20100113111313.3a6f0399@wker> (raw)
In-Reply-To: <1260625941-12179-1-git-send-email-agust@denx.de>
On Sat, 12 Dec 2009 14:52:21 +0100
Anatolij Gustschin <agust@denx.de> wrote:
> Since commit 9d2e9d66a3f032667934144cd61c396ba49f090d
> mptsas driver fails to allocate memory for the MPT chain buffers
> for second LSI adapter on PPC440SPe Katmai platform:
> ...
> ioc1: LSISAS1068E B3: Capabilities={Initiator}
> mptbase: ioc1: ERROR - Unable to allocate Reply, Request, Chain Buffers!
> mptbase: ioc1: ERROR - didn't initialize properly! (-3)
> mptsas: probe of 0002:31:00.0 failed with error -3
>
> This commit increased MPT_FC_CAN_QUEUE value but initChainBuffers()
> doesn't differentiate between SAS and FC causing increased allocation
> for SAS case, too. Later pci_alloc_consistent() fails to allocate
> increased chain buffer pool size for SAS case.
>
> Provide a fix by looking at the bus type and using appropriate
> MPT_SAS_CAN_QUEUE value while calculation of the number of chain
> buffers.
Could someone please comment on this patch? Thanks!
Anatolij
next prev parent reply other threads:[~2010-01-13 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 13:52 [PATCH] [SCSI] mptsas: Fix issue with chain pools allocation on katmai Anatolij Gustschin
2010-01-13 10:13 ` Anatolij Gustschin [this message]
2010-01-13 10:26 ` Desai, Kashyap
2010-01-15 13:12 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113111313.3a6f0399@wker \
--to=agust@denx.de \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=kashyap.desai@lsi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox