From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers Date: Tue, 19 Jan 2010 10:27:10 -0800 Message-ID: <201001191027.10442.dtor@vmware.com> References: <20100119173819.GA28630@dtor-ws.eng.vmware.com> <201001191020.30437.dtor@vmware.com> <1263925423.4398.14.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:38401 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143Ab0ASS1S (ORCPT ); Tue, 19 Jan 2010 13:27:18 -0500 In-Reply-To: <1263925423.4398.14.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Alok Kataria , VMware PV-Drivers , "linux-scsi@vger.kernel.org" On Tuesday 19 January 2010 10:23:43 am James Bottomley wrote: > On Tue, 2010-01-19 at 10:20 -0800, Dmitry Torokhov wrote: > > On Tuesday 19 January 2010 10:19:04 am Alok Kataria wrote: > > > On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote: > > > > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote: > > > > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote: > > > > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is > > > > > > being passed unsigned int. Unsigned int is more proper type for > > > > > > IRQ number so let's use it. This shuts off a compile warning with > > > > > > recent compilers. > > > > > > > > > > > > Signed-off-by: Dmitry Torokhov > > > > > > > > > > LGTM. > > > > > > > > > > Signed-off-by: Alok N Kataria > > > > > > > > That would be acked-by unless you want to resend the patch to me? I > > > > don't have an unmangled copy of it, so someone needs to send it to > > > > the scsi list. > > > > > > Acked-by is fine with me too. If its an hassle to pick these lines > > > after the patch is sent, I am totally fine if you pick the patch > > > without my Acked-by or SOB line, just wanted to acknowledge that the > > > change is fine by me. > > > > Hm, I wonder why the original did not make through to linux-scsi/James. > > I will resend from my other address then. > > Well, sometimes it's because someone is using a mail tool that breaks > threading ... but I did a subject search, it definitely isn't in my > folder. Vger has a fairly esoteric spam reduction mechanism based on > regexps ... perhaps you fell foul of that? Mutt usually does not fail me when sending patches. Let's see if my other account works better. -- Dmitry