* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
@ 2010-01-14 22:27 ` bugzilla-daemon
2010-01-14 23:01 ` Andrew Morton
2010-01-14 23:02 ` bugzilla-daemon
` (9 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-14 22:27 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
Andrew Morton <akpm@linux-foundation.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |akpm@linux-foundation.org,
| |james.smart@emulex.com
Component|PCI |Other
AssignedTo|drivers_pci@kernel-bugs.osd |scsi_drivers-other@kernel-b
|l.org |ugs.osdl.org
Product|Drivers |SCSI Drivers
Regression|No |Yes
--- Comment #2 from Andrew Morton <akpm@linux-foundation.org> 2010-01-14 22:27:15 ---
Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask
you to email a signed-off version of that patch.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
2010-01-14 22:27 ` [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken bugzilla-daemon
@ 2010-01-14 23:01 ` Andrew Morton
2010-01-15 7:23 ` Oleg Gawriloff
0 siblings, 1 reply; 18+ messages in thread
From: Andrew Morton @ 2010-01-14 23:01 UTC (permalink / raw)
To: barzog; +Cc: linux-scsi, bugzilla-daemon, James Smart
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Thu, 14 Jan 2010 22:27:18 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14877
>
>
> Andrew Morton <akpm@linux-foundation.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |akpm@linux-foundation.org,
> | |james.smart@emulex.com
> Component|PCI |Other
> AssignedTo|drivers_pci@kernel-bugs.osd |scsi_drivers-other@kernel-b
> |l.org |ugs.osdl.org
> Product|Drivers |SCSI Drivers
> Regression|No |Yes
>
>
>
>
> --- Comment #2 from Andrew Morton <akpm@linux-foundation.org> 2010-01-14 22:27:15 ---
> Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask
> you to email a signed-off version of that patch.
>
Oleg, please send that lpfc patch via emailed reply-to-all to this email.
Include a brief description for the changelog and a Signed-off-by: as
per Documentation/SubmittingPatches, thanks.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
2010-01-14 23:01 ` Andrew Morton
@ 2010-01-15 7:23 ` Oleg Gawriloff
2010-01-22 23:18 ` Andrew Morton
0 siblings, 1 reply; 18+ messages in thread
From: Oleg Gawriloff @ 2010-01-15 7:23 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-scsi, bugzilla-daemon, James Smart
[-- Attachment #1: Type: text/plain, Size: 1860 bytes --]
15.01.2010 1:01, Andrew Morton пишет:
> Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> Include a brief description for the changelog and a Signed-off-by: as
> per Documentation/SubmittingPatches, thanks.
Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
"Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X
is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
---
drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index e1a30a1..936ecaf 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
/*
# lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
# support this feature
-# 0 = MSI disabled (default)
+# 0 = MSI disabled
# 1 = MSI enabled
-# 2 = MSI-X enabled
+# 2 = MSI-X enabled (default)
# Value range is [0,2]. Default value is 0.
*/
-LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
+LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
"MSI-X (2), if possible");
/*
--
Signed, Oleg Gawriloff.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2914 bytes --]
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
2010-01-15 7:23 ` Oleg Gawriloff
@ 2010-01-22 23:18 ` Andrew Morton
2010-01-23 1:21 ` James Bottomley
0 siblings, 1 reply; 18+ messages in thread
From: Andrew Morton @ 2010-01-22 23:18 UTC (permalink / raw)
To: Oleg Gawriloff; +Cc: linux-scsi, bugzilla-daemon, James Smart
On Fri, 15 Jan 2010 09:23:50 +0200
Oleg Gawriloff <barzog@telecom.by> wrote:
> 15.01.2010 1:01, Andrew Morton __________:
>
> > Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> > Include a brief description for the changelog and a Signed-off-by: as
> > per Documentation/SubmittingPatches, thanks.
> Signed-off-by version available at
> http://marc.info/?l=linux-scsi&m=126342842601776&w=2
>
> From: George Kadianakis <desnacked {bomb} gmail {point} com>
>
> A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
> interrupts.
> This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
> "Addition of SLI4 Interface - Base Support" patch [2] broke.
> It reestablishes MSI-X as the default interrupt method and in case MSI-X
> is not
> supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
>
> [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
> [2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
>
> Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
> ---
> drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index e1a30a1..936ecaf 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
> /*
> # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
> # support this feature
> -# 0 = MSI disabled (default)
> +# 0 = MSI disabled
> # 1 = MSI enabled
> -# 2 = MSI-X enabled
> +# 2 = MSI-X enabled (default)
> # Value range is [0,2]. Default value is 0.
> */
> -LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
> +LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
> "MSI-X (2), if possible");
>
This is committed to the scsi tree without a cc:stable, so it won't get
backported into 2.6.32.x and might not make it into 2.6.33 either.
Was that all intentional?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
2010-01-22 23:18 ` Andrew Morton
@ 2010-01-23 1:21 ` James Bottomley
0 siblings, 0 replies; 18+ messages in thread
From: James Bottomley @ 2010-01-23 1:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: Oleg Gawriloff, linux-scsi, bugzilla-daemon, James Smart
On Fri, 2010-01-22 at 15:18 -0800, Andrew Morton wrote:
> On Fri, 15 Jan 2010 09:23:50 +0200
> Oleg Gawriloff <barzog@telecom.by> wrote:
>
> > 15.01.2010 1:01, Andrew Morton __________:
> >
> > > Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> > > Include a brief description for the changelog and a Signed-off-by: as
> > > per Documentation/SubmittingPatches, thanks.
> > Signed-off-by version available at
> > http://marc.info/?l=linux-scsi&m=126342842601776&w=2
> >
> > From: George Kadianakis <desnacked {bomb} gmail {point} com>
> >
> > A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
> > interrupts.
> > This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
> > "Addition of SLI4 Interface - Base Support" patch [2] broke.
> > It reestablishes MSI-X as the default interrupt method and in case MSI-X
> > is not
> > supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
> >
> > [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
> > [2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
> >
> > Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
> > ---
> > drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >
> > diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> > index e1a30a1..936ecaf 100644
> > --- a/drivers/scsi/lpfc/lpfc_attr.c
> > +++ b/drivers/scsi/lpfc/lpfc_attr.c
> > @@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
> > /*
> > # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
> > # support this feature
> > -# 0 = MSI disabled (default)
> > +# 0 = MSI disabled
> > # 1 = MSI enabled
> > -# 2 = MSI-X enabled
> > +# 2 = MSI-X enabled (default)
> > # Value range is [0,2]. Default value is 0.
> > */
> > -LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
> > +LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
> > "MSI-X (2), if possible");
> >
>
> This is committed to the scsi tree without a cc:stable, so it won't get
> backported into 2.6.32.x and might not make it into 2.6.33 either.
>
> Was that all intentional?
Yes.
The commit contains an essay from James Smart as a sidebar explaining
the logic, but the gist is that there were instabilities in the previous
kernel that caused MSI failures with the lpfc cards so disabling MSI was
deliberate.
James
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
2010-01-14 22:27 ` [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken bugzilla-daemon
@ 2010-01-14 23:02 ` bugzilla-daemon
2010-01-15 7:22 ` bugzilla-daemon
` (8 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-14 23:02 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #3 from Andrew Morton <akpm@linux-foundation.org> 2010-01-14 23:02:19 ---
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Thu, 14 Jan 2010 22:27:18 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=14877
>
>
> Andrew Morton <akpm@linux-foundation.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |akpm@linux-foundation.org,
> | |james.smart@emulex.com
> Component|PCI |Other
> AssignedTo|drivers_pci@kernel-bugs.osd |scsi_drivers-other@kernel-b
> |l.org |ugs.osdl.org
> Product|Drivers |SCSI Drivers
> Regression|No |Yes
>
>
>
>
> --- Comment #2 from Andrew Morton <akpm@linux-foundation.org> 2010-01-14 22:27:15 ---
> Thanks. I'll mark this as a regression, shall reassign to scsi and shall ask
> you to email a signed-off version of that patch.
>
Oleg, please send that lpfc patch via emailed reply-to-all to this email.
Include a brief description for the changelog and a Signed-off-by: as
per Documentation/SubmittingPatches, thanks.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
2010-01-14 22:27 ` [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken bugzilla-daemon
2010-01-14 23:02 ` bugzilla-daemon
@ 2010-01-15 7:22 ` bugzilla-daemon
2010-01-15 7:24 ` bugzilla-daemon
` (7 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-15 7:22 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #4 from Oleg Gawriloff <barzog@telecom.by> 2010-01-15 07:22:42 ---
Sorry, I'm not kernel developer. Signed-off-by version is available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (2 preceding siblings ...)
2010-01-15 7:22 ` bugzilla-daemon
@ 2010-01-15 7:24 ` bugzilla-daemon
2010-01-22 23:18 ` bugzilla-daemon
` (6 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-15 7:24 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #5 from Oleg Gawriloff <barzog@telecom.by> 2010-01-15 07:24:05 ---
15.01.2010 1:01, Andrew Morton пишет:
> Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> Include a brief description for the changelog and a Signed-off-by: as
> per Documentation/SubmittingPatches, thanks.
Signed-off-by version available at
http://marc.info/?l=linux-scsi&m=126342842601776&w=2
From: George Kadianakis <desnacked {bomb} gmail {point} com>
A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
interrupts.
This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
"Addition of SLI4 Interface - Base Support" patch [2] broke.
It reestablishes MSI-X as the default interrupt method and in case MSI-X
is not
supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
[1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
[2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
---
drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index e1a30a1..936ecaf 100644
--- a/drivers/scsi/lpfc/lpfc_attr.c
+++ b/drivers/scsi/lpfc/lpfc_attr.c
@@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
/*
# lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
# support this feature
-# 0 = MSI disabled (default)
+# 0 = MSI disabled
# 1 = MSI enabled
-# 2 = MSI-X enabled
+# 2 = MSI-X enabled (default)
# Value range is [0,2]. Default value is 0.
*/
-LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
+LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
"MSI-X (2), if possible");
/*
--
Signed, Oleg Gawriloff.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (3 preceding siblings ...)
2010-01-15 7:24 ` bugzilla-daemon
@ 2010-01-22 23:18 ` bugzilla-daemon
2010-01-23 14:25 ` bugzilla-daemon
` (5 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-22 23:18 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #6 from Andrew Morton <akpm@linux-foundation.org> 2010-01-22 23:18:19 ---
On Fri, 15 Jan 2010 09:23:50 +0200
Oleg Gawriloff <barzog@telecom.by> wrote:
> 15.01.2010 1:01, Andrew Morton __________:
>
> > Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> > Include a brief description for the changelog and a Signed-off-by: as
> > per Documentation/SubmittingPatches, thanks.
> Signed-off-by version available at
> http://marc.info/?l=linux-scsi&m=126342842601776&w=2
>
> From: George Kadianakis <desnacked {bomb} gmail {point} com>
>
> A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
> interrupts.
> This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
> "Addition of SLI4 Interface - Base Support" patch [2] broke.
> It reestablishes MSI-X as the default interrupt method and in case MSI-X
> is not
> supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
>
> [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
> [2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
>
> Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
> ---
> drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index e1a30a1..936ecaf 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
> /*
> # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
> # support this feature
> -# 0 = MSI disabled (default)
> +# 0 = MSI disabled
> # 1 = MSI enabled
> -# 2 = MSI-X enabled
> +# 2 = MSI-X enabled (default)
> # Value range is [0,2]. Default value is 0.
> */
> -LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
> +LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
> "MSI-X (2), if possible");
>
This is committed to the scsi tree without a cc:stable, so it won't get
backported into 2.6.32.x and might not make it into 2.6.33 either.
Was that all intentional?
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (4 preceding siblings ...)
2010-01-22 23:18 ` bugzilla-daemon
@ 2010-01-23 14:25 ` bugzilla-daemon
2010-01-23 14:29 ` bugzilla-daemon
` (4 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-23 14:25 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #7 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org> 2010-01-23 14:25:26 ---
Reply-To: James.Bottomley@suse.de
On Fri, 2010-01-22 at 15:18 -0800, Andrew Morton wrote:
> On Fri, 15 Jan 2010 09:23:50 +0200
> Oleg Gawriloff <barzog@telecom.by> wrote:
>
> > 15.01.2010 1:01, Andrew Morton __________:
> >
> > > Oleg, please send that lpfc patch via emailed reply-to-all to this email.
> > > Include a brief description for the changelog and a Signed-off-by: as
> > > per Documentation/SubmittingPatches, thanks.
> > Signed-off-by version available at
> > http://marc.info/?l=linux-scsi&m=126342842601776&w=2
> >
> > From: George Kadianakis <desnacked {bomb} gmail {point} com>
> >
> > A Gentoo bug report [1] showed that as of 2.6.31 lpfc only uses INTx
> > interrupts.
> > This patch restores lpfc's ability to support MSI-X/MSI interrupts that the
> > "Addition of SLI4 Interface - Base Support" patch [2] broke.
> > It reestablishes MSI-X as the default interrupt method and in case MSI-X
> > is not
> > supported lpfc_sli{4,}_enable_intr fallbacks to MSI and then to INTx.
> >
> > [1]: http://bugs.gentoo.org/show_bug.cgi?id=296319
> > [2]: commit da0436e915a5c17ee79e72c1bf978a4ebb1cbf4d
> >
> > Signed-off-by: George Kadianakis <desnacked {cat} gmail {dog} com>
> > ---
> > drivers/scsi/lpfc/lpfc_attr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >
> > diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> > index e1a30a1..936ecaf 100644
> > --- a/drivers/scsi/lpfc/lpfc_attr.c
> > +++ b/drivers/scsi/lpfc/lpfc_attr.c
> > @@ -2890,12 +2890,12 @@ LPFC_ATTR_RW(poll_tmo, 10, 1, 255,
> > /*
> > # lpfc_use_msi: Use MSI (Message Signaled Interrupts) in systems that
> > # support this feature
> > -# 0 = MSI disabled (default)
> > +# 0 = MSI disabled
> > # 1 = MSI enabled
> > -# 2 = MSI-X enabled
> > +# 2 = MSI-X enabled (default)
> > # Value range is [0,2]. Default value is 0.
> > */
> > -LPFC_ATTR_R(use_msi, 0, 0, 2, "Use Message Signaled Interrupts (1) or "
> > +LPFC_ATTR_R(use_msi, 2, 0, 2, "Use Message Signaled Interrupts (1) or "
> > "MSI-X (2), if possible");
> >
>
> This is committed to the scsi tree without a cc:stable, so it won't get
> backported into 2.6.32.x and might not make it into 2.6.33 either.
>
> Was that all intentional?
Yes.
The commit contains an essay from James Smart as a sidebar explaining
the logic, but the gist is that there were instabilities in the previous
kernel that caused MSI failures with the lpfc cards so disabling MSI was
deliberate.
James
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (5 preceding siblings ...)
2010-01-23 14:25 ` bugzilla-daemon
@ 2010-01-23 14:29 ` bugzilla-daemon
2010-01-23 14:57 ` James Bottomley
2010-01-23 14:57 ` bugzilla-daemon
` (3 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-23 14:29 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #8 from Oleg Gawriloff <barzog@telecom.by> 2010-01-23 14:29:11 ---
Hmm, I've running my system without any problems more then year. I've
understand the point that if someone see MSI instability on lpfc it should be
turned off by default, but is there any way to activate MSI by hand?
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
2010-01-23 14:29 ` bugzilla-daemon
@ 2010-01-23 14:57 ` James Bottomley
0 siblings, 0 replies; 18+ messages in thread
From: James Bottomley @ 2010-01-23 14:57 UTC (permalink / raw)
To: bugzilla-daemon; +Cc: linux-scsi
On Sat, 2010-01-23 at 14:29 +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> --- Comment #8 from Oleg Gawriloff <barzog@telecom.by> 2010-01-23 14:29:11 ---
> Hmm, I've running my system without any problems more then year. I've
> understand the point that if someone see MSI instability on lpfc it should be
> turned off by default, but is there any way to activate MSI by hand?
Yes, with the module parameter. Just set it to 2 again and it will do
MSI.
James
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (6 preceding siblings ...)
2010-01-23 14:29 ` bugzilla-daemon
@ 2010-01-23 14:57 ` bugzilla-daemon
2010-01-23 15:36 ` bugzilla-daemon
` (2 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-23 14:57 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #9 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org> 2010-01-23 14:57:20 ---
Reply-To: James.Bottomley@suse.de
On Sat, 2010-01-23 at 14:29 +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> --- Comment #8 from Oleg Gawriloff <barzog@telecom.by> 2010-01-23 14:29:11 ---
> Hmm, I've running my system without any problems more then year. I've
> understand the point that if someone see MSI instability on lpfc it should be
> turned off by default, but is there any way to activate MSI by hand?
Yes, with the module parameter. Just set it to 2 again and it will do
MSI.
James
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (7 preceding siblings ...)
2010-01-23 14:57 ` bugzilla-daemon
@ 2010-01-23 15:36 ` bugzilla-daemon
2010-01-23 22:34 ` bugzilla-daemon
2010-01-24 1:22 ` bugzilla-daemon
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-23 15:36 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #10 from Oleg Gawriloff <barzog@telecom.by> 2010-01-23 15:36:40 ---
Tried (I'm on Gentoo) on 2.6.32.4 kernel:
/etc/modules.autoload.d/kernel-2.6:
lpfc lpfc_use_msi=2
nothing changes (still on IO-APIC-fasteoi).
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (8 preceding siblings ...)
2010-01-23 15:36 ` bugzilla-daemon
@ 2010-01-23 22:34 ` bugzilla-daemon
2010-01-24 1:22 ` bugzilla-daemon
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-23 22:34 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #11 from James Smart <james.smart@emulex.com> 2010-01-23 22:34:26 ---
Note: this isn't a problem with lpfc - it was a problem with a couple of
specific hardware platforms that didn't properly support MSI.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug 14877] MSI/MSI-X support in 2.6.31.xx and 2.6.32.xx seems broken
[not found] <bug-14877-11613@http.bugzilla.kernel.org/>
` (9 preceding siblings ...)
2010-01-23 22:34 ` bugzilla-daemon
@ 2010-01-24 1:22 ` bugzilla-daemon
10 siblings, 0 replies; 18+ messages in thread
From: bugzilla-daemon @ 2010-01-24 1:22 UTC (permalink / raw)
To: linux-scsi
http://bugzilla.kernel.org/show_bug.cgi?id=14877
--- Comment #12 from James Smart <james.smart@emulex.com> 2010-01-24 01:22:30 ---
BTW: for your test - it depends on what adapter you have as to whether it
supports MSI-X, MSI, or only INTx.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 18+ messages in thread