From: Robert Love <robert.w.love@intel.com>
To: James.Bottomley@suse.de, linux-scsi@vger.kernel.org
Cc: Hugh Daschbach <hdasch@broadcom.com>,
Joe Eykholt <jeykholt@cisco.com>,
Robert Love <robert.w.love@intel.com>
Subject: [PATCH 2/9] libfc: Fix e_d_tov ns -> ms scaling factor in PLOGI response.
Date: Tue, 16 Feb 2010 12:15:23 -0800 [thread overview]
Message-ID: <20100216201523.26581.60460.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100216201513.26581.83756.stgit@localhost.localdomain>
From: Hugh Daschbach <hdasch@broadcom.com>
Both PLOGI and RTV response processing conditionally scale e_d_tov,
but use different scaling factors. The scaling factor is correct in
RTV response processing. Bring PLOGI e_d_tov scaling in line with RTV
common service parameter inspection.
Signed-off-by: Hugh Daschbach <hdasch@broadcom.com>
Acked-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---
drivers/scsi/libfc/fc_rport.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 0230052..97923bb 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -623,7 +623,7 @@ static void fc_rport_plogi_resp(struct fc_seq *sp, struct fc_frame *fp,
tov = ntohl(plp->fl_csp.sp_e_d_tov);
if (ntohs(plp->fl_csp.sp_features) & FC_SP_FT_EDTR)
- tov /= 1000;
+ tov /= 1000000;
if (tov > rdata->e_d_tov)
rdata->e_d_tov = tov;
csp_seq = ntohs(plp->fl_csp.sp_tot_seq);
next prev parent reply other threads:[~2010-02-16 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 20:15 [PATCH 0/9] Updates to libfc, libfcoe, fcoe and fnic Robert Love
2010-02-16 20:15 ` [PATCH 1/9] libfc: call ddp setup for only FCP reads to avoid accessing junk fsp pointer Robert Love
2010-02-16 20:15 ` Robert Love [this message]
2010-02-16 20:15 ` [PATCH 3/9] libfc: Don't assume response request present Robert Love
2010-02-16 20:15 ` [PATCH 4/9] libfcoe: Send port LKA every FIP_VN_KA_PERIOD secs Robert Love
2010-02-16 20:15 ` [PATCH 5/9] fcoe: Only rmmod fcoe.ko if there are no active connections Robert Love
2010-02-16 20:15 ` [PATCH 6/9] fnic: Allow multicast and unicast address registrations for fnic Robert Love
2010-02-16 20:15 ` [PATCH 7/9] fnic: lport stats need to be initialized in fnic_probe() Robert Love
2010-02-16 20:15 ` [PATCH 8/9] fnic: Set fnic driver version Robert Love
2010-02-16 20:16 ` [PATCH 9/9] MAINTAINERS: Adding FCoE information to the MAINTAINERS file Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216201523.26581.60460.stgit@localhost.localdomain \
--to=robert.w.love@intel.com \
--cc=James.Bottomley@suse.de \
--cc=hdasch@broadcom.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox