public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Love <robert.w.love@intel.com>
To: James.Bottomley@suse.de, linux-scsi@vger.kernel.org
Cc: Brian Uchino <buchino@cisco.com>, Herman Lee <hermlee@cisco.com>,
	Robert Love <robert.w.love@intel.com>
Subject: [PATCH 6/9] fnic: Allow multicast and unicast address registrations for fnic
Date: Tue, 16 Feb 2010 12:15:44 -0800	[thread overview]
Message-ID: <20100216201544.26581.37215.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100216201513.26581.83756.stgit@localhost.localdomain>

From: Venkata Siva Vijayendra Bhamidipati <vbhamidi@cisco.com>

To enable FIP support in fnic, we have to register with hardware to receive
FIP solication frames on a well-known multicast address.
Before FIP support, the firmware interface allowed multicast address
registrations only for enic devices. This is a minor change in fnic to
allow the firmware interface to now register mcast addresses for fnic too.

Signed-off-by: Brian Uchino <buchino@cisco.com>
Signed-off-by: Herman Lee <hermlee@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---

 drivers/scsi/fnic/fnic_main.c   |    2 ++
 drivers/scsi/fnic/vnic_devcmd.h |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index fe1b103..5bab7e0 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -620,6 +620,8 @@ static int __devinit fnic_probe(struct pci_dev *pdev,
 	if (fnic->config.flags & VFCF_FIP_CAPABLE) {
 		shost_printk(KERN_INFO, fnic->lport->host,
 			     "firmware supports FIP\n");
+		/* enable directed and multicast */
+		vnic_dev_packet_filter(fnic->vdev, 1, 1, 0, 0, 0);
 		vnic_dev_add_addr(fnic->vdev, FIP_ALL_ENODE_MACS);
 		vnic_dev_add_addr(fnic->vdev, fnic->ctlr.ctl_src_addr);
 	} else {
diff --git a/drivers/scsi/fnic/vnic_devcmd.h b/drivers/scsi/fnic/vnic_devcmd.h
index d62b906..7c9ccbd 100644
--- a/drivers/scsi/fnic/vnic_devcmd.h
+++ b/drivers/scsi/fnic/vnic_devcmd.h
@@ -94,7 +94,7 @@ enum vnic_devcmd_cmd {
 	CMD_STATS_DUMP          = _CMDC(_CMD_DIR_WRITE, _CMD_VTYPE_ALL, 4),
 
 	/* set Rx packet filter: (u32)a0=filters (see CMD_PFILTER_*) */
-	CMD_PACKET_FILTER	= _CMDCNW(_CMD_DIR_WRITE, _CMD_VTYPE_ENET, 7),
+	CMD_PACKET_FILTER       = _CMDCNW(_CMD_DIR_WRITE, _CMD_VTYPE_ALL, 7),
 
 	/* hang detection notification */
 	CMD_HANG_NOTIFY         = _CMDC(_CMD_DIR_NONE, _CMD_VTYPE_ALL, 8),


  parent reply	other threads:[~2010-02-16 20:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 20:15 [PATCH 0/9] Updates to libfc, libfcoe, fcoe and fnic Robert Love
2010-02-16 20:15 ` [PATCH 1/9] libfc: call ddp setup for only FCP reads to avoid accessing junk fsp pointer Robert Love
2010-02-16 20:15 ` [PATCH 2/9] libfc: Fix e_d_tov ns -> ms scaling factor in PLOGI response Robert Love
2010-02-16 20:15 ` [PATCH 3/9] libfc: Don't assume response request present Robert Love
2010-02-16 20:15 ` [PATCH 4/9] libfcoe: Send port LKA every FIP_VN_KA_PERIOD secs Robert Love
2010-02-16 20:15 ` [PATCH 5/9] fcoe: Only rmmod fcoe.ko if there are no active connections Robert Love
2010-02-16 20:15 ` Robert Love [this message]
2010-02-16 20:15 ` [PATCH 7/9] fnic: lport stats need to be initialized in fnic_probe() Robert Love
2010-02-16 20:15 ` [PATCH 8/9] fnic: Set fnic driver version Robert Love
2010-02-16 20:16 ` [PATCH 9/9] MAINTAINERS: Adding FCoE information to the MAINTAINERS file Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100216201544.26581.37215.stgit@localhost.localdomain \
    --to=robert.w.love@intel.com \
    --cc=James.Bottomley@suse.de \
    --cc=buchino@cisco.com \
    --cc=hermlee@cisco.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox