From: Matthew Wilcox <matthew@wil.cx>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Dan Carpenter <error27@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: bug report: sd: off by one in sd_read_block_limits()
Date: Tue, 2 Mar 2010 06:31:24 -0700 [thread overview]
Message-ID: <20100302133124.GF6567@parisc-linux.org> (raw)
In-Reply-To: <yq1k4tu2716.fsf@sermon.lab.mkp.net>
On Tue, Mar 02, 2010 at 08:21:41AM -0500, Martin K. Petersen wrote:
> >>>>> "Martin" == Martin K Petersen <martin.petersen@oracle.com> writes:
>
> Actually, looking closer at the VPD mechanism in e3deec09 we need to fit
> the page header as well...
These aren't the only two bugs introduced either. If a device has more VPD
pages than the length of the buffer that the caller has allocated, we will
now incorrectly report that the device doesn't support that page.
James, was any problem actually observed that led to e3deec09? I really
think you should revert it.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2010-03-02 13:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 8:21 bug report: sd: off by one in sd_read_block_limits() Dan Carpenter
2010-03-02 13:12 ` Martin K. Petersen
2010-03-02 13:21 ` Martin K. Petersen
2010-03-02 13:31 ` Matthew Wilcox [this message]
2010-03-02 13:36 ` Martin K. Petersen
2010-03-02 14:56 ` Matthew Wilcox
2010-03-03 7:08 ` James Bottomley
2010-03-02 13:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302133124.GF6567@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@suse.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox