* [PATCH] Remove slash in QlogicPTI irq name
@ 2010-03-08 18:23 Meelis Roos
2010-03-08 18:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Meelis Roos @ 2010-03-08 18:23 UTC (permalink / raw)
To: linux-scsi, sparclinux
qlogicpti driver registers its irq with a name containing slash.
This results in
[ 71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8()
[ 71.132815] name 'Qlogic/PTI'
because proc_mkdir with the name of the irq fails. Fix it by just
removing the slash from irq name. Discovered and tested on real hardware
(Sun Ultra 1).
Signed-off-by: Meelis Roos <mroos@linux.ee>
diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index fa34b92..1b82170 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -738,7 +738,7 @@ static int __devinit qpti_register_irq(struct qlogicpti *qpti)
* sanely maintain.
*/
if (request_irq(qpti->irq, qpti_intr,
- IRQF_SHARED, "Qlogic/PTI", qpti))
+ IRQF_SHARED, "QlogicPTI", qpti))
goto fail;
printk("qlogicpti%d: IRQ %d ", qpti->qpti_id, qpti->irq);
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove slash in QlogicPTI irq name
2010-03-08 18:23 [PATCH] Remove slash in QlogicPTI irq name Meelis Roos
@ 2010-03-08 18:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-03-08 18:53 UTC (permalink / raw)
To: mroos; +Cc: linux-scsi, sparclinux
From: Meelis Roos <mroos@linux.ee>
Date: Mon, 8 Mar 2010 20:23:20 +0200 (EET)
> qlogicpti driver registers its irq with a name containing slash.
> This results in
>
> [ 71.049735] WARNING: at fs/proc/generic.c:316 __xlate_proc_name+0xa8/0xb8()
> [ 71.132815] name 'Qlogic/PTI'
>
> because proc_mkdir with the name of the irq fails. Fix it by just
> removing the slash from irq name. Discovered and tested on real hardware
> (Sun Ultra 1).
>
> Signed-off-by: Meelis Roos <mroos@linux.ee>
Applied, thanks a lot!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-08 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 18:23 [PATCH] Remove slash in QlogicPTI irq name Meelis Roos
2010-03-08 18:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).