From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: James Bottomley <James.Bottomley@suse.de>,
Eric Moore <Eric.Moore@lsi.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH RESEND] mptscsih: Fix first line of kernel-doc for a few functions
Date: Wed, 31 Mar 2010 09:13:12 -0700 [thread overview]
Message-ID: <20100331091312.bcd848c2.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1269404879.18314.276.camel@localhost>
On Wed, 24 Mar 2010 04:27:59 +0000 Ben Hutchings wrote:
> The function name must be followed by a space, hypen, space, and a
> short description.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
James, will you be handling this patch or should I?
> ---
> drivers/message/fusion/mptscsih.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> index 4a7d1af..53516ed 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -2560,9 +2560,7 @@ mptscsih_getclear_scsi_lookup(MPT_ADAPTER *ioc, int i)
> }
>
> /**
> - * mptscsih_set_scsi_lookup
> - *
> - * writes a scmd entry into the ScsiLookup[] array list
> + * mptscsih_set_scsi_lookup - write a scmd entry into the ScsiLookup[] array list
> *
> * @ioc: Pointer to MPT_ADAPTER structure
> * @i: index into the array
> @@ -2725,7 +2723,7 @@ mptscsih_scandv_complete(MPT_ADAPTER *ioc, MPT_FRAME_HDR *req,
>
>
> /**
> - * mptscsih_get_completion_code -
> + * mptscsih_get_completion_code - get completion code from MPT request
> * @ioc: Pointer to MPT_ADAPTER structure
> * @req: Pointer to original MPT request frame
> * @reply: Pointer to MPT reply frame (NULL if TurboReply)
> --
Thanks,
---
~Randy
prev parent reply other threads:[~2010-03-31 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1266157055.10567.13.camel@localhost>
2010-02-14 14:21 ` [PATCH 5/5] mptscsih: Fix first line of kernel-doc for a few functions Ben Hutchings
2010-03-24 4:27 ` [PATCH RESEND] " Ben Hutchings
2010-03-31 16:13 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331091312.bcd848c2.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=Eric.Moore@lsi.com \
--cc=James.Bottomley@suse.de \
--cc=ben@decadent.org.uk \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox