From: Andrew Morton <akpm@linux-foundation.org>
To: Jing Huang <huangj@Brocade.com>
Cc: sfr@canb.auug.org.au, James.Bottomley@suse.de,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, kgudipat@Brocade.com,
rvadivel@Brocade.com, vravindr@Brocade.com
Subject: Re: [PATCH] bfa: fix compilation warning in powerpc (resend)
Date: Wed, 21 Apr 2010 16:12:17 -0700 [thread overview]
Message-ID: <20100421161217.60d5654b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1271186549-642-1-git-send-email-huangj@brocade.com>
On Tue, 13 Apr 2010 12:22:29 -0700
Jing Huang <huangj@Brocade.com> wrote:
> Fix the compilation warning in powerpc.
When fixing a warning, please quote that warning in the patch description!
<does a cross-build>
It seems that you're referring to this:
drivers/scsi/bfa/bfa_ioc.c: In function 'bfa_ioc_msgget':
drivers/scsi/bfa/bfa_ioc.c:1331: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_notify_hbfail':
drivers/scsi/bfa/bfa_ioc_ct.c:177: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c:180: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_pll_init':
drivers/scsi/bfa/bfa_ioc_ct.c:381: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_ownership_reset':
drivers/scsi/bfa/bfa_ioc_ct.c:421: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_notify_hbfail':
drivers/scsi/bfa/bfa_ioc_cb.c:99: warning: value computed is not used
drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_ownership_reset':
drivers/scsi/bfa/bfa_ioc_cb.c:272: warning: value computed is not used
> The same change also fixes endian
> issue we found in powerpc test.
When fixing a bug, please fully describe the bug!
If this driver has "endian issues" on powerpc then it's quite possible
that this is a running-around-with-hair-on-fire,
must-backport-to-2.6.33.x bugfix.
But how would I know? You didn't tell me!
next prev parent reply other threads:[~2010-04-21 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 19:22 [PATCH] bfa: fix compilation warning in powerpc (resend) Jing Huang
2010-04-21 23:12 ` Andrew Morton [this message]
2010-04-22 19:50 ` Jing Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421161217.60d5654b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@suse.de \
--cc=huangj@Brocade.com \
--cc=kgudipat@Brocade.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rvadivel@Brocade.com \
--cc=sfr@canb.auug.org.au \
--cc=vravindr@Brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox