From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Anderson Subject: Re: [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set Date: Tue, 4 May 2010 10:58:55 -0700 Message-ID: <20100504175855.GB16156@linux.vnet.ibm.com> References: <1272944228-30511-1-git-send-email-andmike@linux.vnet.ibm.com> <1272944228-30511-3-git-send-email-andmike@linux.vnet.ibm.com> <20100504104709.GO27497@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e8.ny.us.ibm.com ([32.97.182.138]:56037 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757243Ab0EDR67 (ORCPT ); Tue, 4 May 2010 13:58:59 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e8.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o44Hmlq5032654 for ; Tue, 4 May 2010 13:48:47 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o44Hwvwv158396 for ; Tue, 4 May 2010 13:58:57 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o44Hwugu012248 for ; Tue, 4 May 2010 13:58:57 -0400 Content-Disposition: inline In-Reply-To: <20100504104709.GO27497@kernel.dk> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jens Axboe Cc: linux-scsi@vger.kernel.org, James Bottomley , dm-devel@redhat.com Jens Axboe wrote: > On Mon, May 03 2010, Mike Anderson wrote: > > Having REQ_DONTPREP set on a request can indicated that resources have been > > allocated for this request. In elv_abort_queue skip requests with > > REQ_DONTPREP set to avoid leaking resources. > > This also seems weird, are you coding the API backwards from what SCSI > currently has implemented? > Yes I was coding to current SCSI implementation. > Would seem a lot cleaner to separate dont-prep from already-prepped. > I assumed to do this we would need another request flag indicating ??REQ_PREPPED?? that would need to be set in the prep function. Then this flag would be checked vs REQ_DONTPREP to call the unprep_fn or did you mean something else? -andmike -- Michael Anderson andmike@linux.vnet.ibm.com