linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Love <robert.w.love@intel.com>
To: James.Bottomley@suse.de, linux-scsi@vger.kernel.org
Cc: Joe Eykholt <jeykholt@cisco.com>, Robert Love <robert.w.love@intel.com>
Subject: [PATCH 01/10] libfc: set seq_id for incoming sequence
Date: Fri, 07 May 2010 15:18:13 -0700	[thread overview]
Message-ID: <20100507221813.14971.63789.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100507221804.14971.11739.stgit@localhost.localdomain>

From: Joe Eykholt <jeykholt@cisco.com>

After the recent patch "fixes unnecessary seq id jump"
the SCST module fcst stopped working because multi-sequence
write data wasn't finding the sequence after the first frame.

Add back the setting of the seq_id when the first frame arrives.
Also fix indentation on two lines.

Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---

 drivers/scsi/libfc/fc_exch.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index daff880..6addbd6 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -918,6 +918,7 @@ static enum fc_pf_rjt_reason fc_seq_lookup_recip(struct fc_lport *lport,
 	if (fc_sof_is_init(fr_sof(fp))) {
 		sp = &ep->seq;
 		sp->ssb_stat |= SSB_ST_RESP;
+		sp->id = fh->fh_seq_id;
 	} else {
 		sp = &ep->seq;
 		if (sp->id != fh->fh_seq_id) {
@@ -1322,11 +1323,12 @@ static void fc_exch_recv_seq_resp(struct fc_exch_mgr *mp, struct fc_frame *fp)
 	}
 	sof = fr_sof(fp);
 	sp = &ep->seq;
-	if (fc_sof_is_init(sof))
+	if (fc_sof_is_init(sof)) {
 		sp->ssb_stat |= SSB_ST_RESP;
-	else if (sp->id != fh->fh_seq_id) {
-			atomic_inc(&mp->stats.seq_not_found);
-			goto rel;
+		sp->id = fh->fh_seq_id;
+	} else if (sp->id != fh->fh_seq_id) {
+		atomic_inc(&mp->stats.seq_not_found);
+		goto rel;
 	}
 
 	f_ctl = ntoh24(fh->fh_f_ctl);


  reply	other threads:[~2010-05-07 22:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-07 22:18 [PATCH 00/10] libfc, libfcoe and fcoe fixes for scsi-misc Robert Love
2010-05-07 22:18 ` Robert Love [this message]
2010-05-07 22:18 ` [PATCH 02/10] fcoe: fixes wrong error exit in fcoe_create Robert Love
2010-05-07 22:18 ` [PATCH 03/10] libfc: Remove unused fc_get_host_port_type Robert Love
2010-05-07 22:18 ` [PATCH 04/10] libfc: Remove extra pointer check Robert Love
2010-05-07 22:18 ` [PATCH 05/10] fcoe: move link speed checking into its own routine Robert Love
2010-05-07 22:18 ` [PATCH 06/10] libfc: Move the port_id into lport Robert Love
2010-05-07 22:18 ` [PATCH 07/10] fcoe: fix a circular locking issue with rtnl and sysfs mutex Robert Love
2010-05-07 22:18 ` [PATCH 08/10] libfcoe: Fix incorrect MAC address clearing Robert Love
2010-05-07 22:18 ` [PATCH 09/10] libfcoe: FIP Keep-Alive messages for VPorts are sent with incorrect port_id and wwn Robert Love
2010-05-07 22:19 ` [PATCH 10/10] fcoe: fix fcoe module ref counting Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100507221813.14971.63789.stgit@localhost.localdomain \
    --to=robert.w.love@intel.com \
    --cc=James.Bottomley@suse.de \
    --cc=jeykholt@cisco.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).