From: Robert Love <robert.w.love@intel.com>
To: James.Bottomley@suse.de, linux-scsi@vger.kernel.org
Cc: Kaladhar Musunuru <kmusunuru@juniper.net>,
Joe Eykholt <jeykholt@cisco.com>,
Robert Love <robert.w.love@intel.com>
Subject: [PATCH 08/10] libfcoe: Fix incorrect MAC address clearing
Date: Fri, 07 May 2010 15:18:52 -0700 [thread overview]
Message-ID: <20100507221852.14971.2206.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100507221804.14971.11739.stgit@localhost.localdomain>
From: Kaladhar Musunuru <kmusunuru@juniper.net>
Fix typo in memset. Incorrect length parameter to memset resulting non-zero MAC address in FPMA messages.
Signed-off-by: Kaladhar Musunuru <kmusunuru@juniper.net>
Acked-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
---
drivers/scsi/fcoe/libfcoe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index 948364a..080e4ec 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -439,7 +439,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport,
cap->encaps.fd_desc.fip_dlen = dlen / FIP_BPW;
mac = (struct fip_mac_desc *)skb_put(skb, sizeof(*mac));
- memset(mac, 0, sizeof(mac));
+ memset(mac, 0, sizeof(*mac));
mac->fd_desc.fip_dtype = FIP_DT_MAC;
mac->fd_desc.fip_dlen = sizeof(*mac) / FIP_BPW;
if (dtype != FIP_DT_FLOGI && dtype != FIP_DT_FDISC) {
next prev parent reply other threads:[~2010-05-07 22:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 22:18 [PATCH 00/10] libfc, libfcoe and fcoe fixes for scsi-misc Robert Love
2010-05-07 22:18 ` [PATCH 01/10] libfc: set seq_id for incoming sequence Robert Love
2010-05-07 22:18 ` [PATCH 02/10] fcoe: fixes wrong error exit in fcoe_create Robert Love
2010-05-07 22:18 ` [PATCH 03/10] libfc: Remove unused fc_get_host_port_type Robert Love
2010-05-07 22:18 ` [PATCH 04/10] libfc: Remove extra pointer check Robert Love
2010-05-07 22:18 ` [PATCH 05/10] fcoe: move link speed checking into its own routine Robert Love
2010-05-07 22:18 ` [PATCH 06/10] libfc: Move the port_id into lport Robert Love
2010-05-07 22:18 ` [PATCH 07/10] fcoe: fix a circular locking issue with rtnl and sysfs mutex Robert Love
2010-05-07 22:18 ` Robert Love [this message]
2010-05-07 22:18 ` [PATCH 09/10] libfcoe: FIP Keep-Alive messages for VPorts are sent with incorrect port_id and wwn Robert Love
2010-05-07 22:19 ` [PATCH 10/10] fcoe: fix fcoe module ref counting Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507221852.14971.2206.stgit@localhost.localdomain \
--to=robert.w.love@intel.com \
--cc=James.Bottomley@suse.de \
--cc=jeykholt@cisco.com \
--cc=kmusunuru@juniper.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).