linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 06/26] drivers/scsi/libsas: use SAM_GOOD
@ 2010-05-24 19:22 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-05-24 19:22 UTC (permalink / raw)
  To: James.Bottomley; +Cc: linux-scsi, akpm, julia

From: Julia Lawall <julia@diku.dk>

The field stat->stat should be compared to SAM_GOOD, not SAM_STAT_GOOD, as
done elsewhere in the same function.  Both constants have the same value.

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/libsas/sas_ata.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/scsi/libsas/sas_ata.c~drivers-scsi-libsas-use-sam_good drivers/scsi/libsas/sas_ata.c
--- a/drivers/scsi/libsas/sas_ata.c~drivers-scsi-libsas-use-sam_good
+++ a/drivers/scsi/libsas/sas_ata.c
@@ -113,7 +113,7 @@ static void sas_ata_task_done(struct sas
 		dev->sata_dev.sstatus = resp->sstatus;
 		dev->sata_dev.serror = resp->serror;
 		dev->sata_dev.scontrol = resp->scontrol;
-	} else if (stat->stat != SAM_STAT_GOOD) {
+	} else if (stat->stat != SAM_GOOD) {
 		ac = sas_to_ata_err(stat);
 		if (ac) {
 			SAS_DPRINTK("%s: SAS error %x\n", __func__,
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-24 19:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-24 19:22 [patch 06/26] drivers/scsi/libsas: use SAM_GOOD akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).