From: Randy Dunlap <rdunlap@xenotime.net>
To: Neela Syam Kolli <megaraidlinux@lsi.com>
Cc: scsi <linux-scsi@vger.kernel.org>
Subject: Re: megaraid sparse warnings
Date: Wed, 26 May 2010 14:28:02 -0700 [thread overview]
Message-ID: <20100526142802.1c06d5c1.rdunlap@xenotime.net> (raw)
In-Reply-To: <4B7788B8.8090005@xenotime.net>
ping??
On Sat, 13 Feb 2010 21:23:04 -0800 Randy Dunlap wrote:
> Hi,
>
> sparse produces these warnings:
>
> drivers/scsi/megaraid.c:307:65: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:309:65: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:313:67: warning: right shift by bigger than source value
> drivers/scsi/megaraid.c:315:67: warning: right shift by bigger than source value
>
> on this source code:
>
> /* use HP firmware and bios version encoding */
> if (adapter->product_info.subsysvid == HP_SUBSYS_VID) {
> sprintf (adapter->fw_version, "%c%d%d.%d%d",
> adapter->product_info.fw_version[2],
> adapter->product_info.fw_version[1] >> 8,
> adapter->product_info.fw_version[1] & 0x0f,
> adapter->product_info.fw_version[0] >> 8,
> adapter->product_info.fw_version[0] & 0x0f);
> sprintf (adapter->bios_version, "%c%d%d.%d%d",
> adapter->product_info.bios_version[2],
> adapter->product_info.bios_version[1] >> 8,
> adapter->product_info.bios_version[1] & 0x0f,
> adapter->product_info.bios_version[0] >> 8,
> adapter->product_info.bios_version[0] & 0x0f);
> } else {
>
>
> Are the fw_version and bios_version fields more than 8 bits each for HP subsys VID
> products? Do HP VID products need a different struct so that they print this info
> correctly?
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2010-05-26 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 5:23 megaraid sparse warnings Randy Dunlap
2010-05-26 21:28 ` Randy Dunlap [this message]
2010-05-26 21:39 ` Al Viro
2010-05-26 22:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526142802.1c06d5c1.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).