From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference Date: Thu, 27 May 2010 18:53:02 +0200 Message-ID: <20100527165301.GU22515@bicker> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: HighPoint Linux Team , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote: > If it is a problem to use 0 when host is NULL, then the code could be fixed > in another way. > Yeah. It seems like it would be better to give a clearly bogus number. I would have said -1 but "scsi-1" looks normal so maybe something like 9999999? regards, dan carpenter