From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: linux-scsi@vger.kernel.org,
James.Bottomley@hansenpartnership.com, dab@hp.com,
mikem@beardog.cce.hp.com
Subject: Re: [PATCH 08/24] hpsa: fix leak of ioremapped memory
Date: Fri, 28 May 2010 21:12:17 +0200 [thread overview]
Message-ID: <201005282112.24802.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20100527201322.3116.86053.stgit@beardog.cce.hp.com>
[-- Attachment #1: Type: Text/Plain, Size: 860 bytes --]
Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> hpsa: fix leak of ioremapped memory
> in hpsa_pci_init error path.
If you had used devres to track your resources you got this for free.
> @@ -3474,6 +3477,12 @@ static int __devinit hpsa_pci_init(struct ctlr_info
> *h) return 0;
>
> err_out_free_res:
> + if (h->transtable)
> + iounmap(h->transtable);
> + if (h->cfgtable)
> + iounmap(h->cfgtable);
> + if (h->vaddr)
> + iounmap(h->vaddr);
I wonder if that shouldn't use pci_iomap() instead. Also the page aligning
tricks in remap_pci_mem() look a bit dubious to me. If your pci BAR is >=
PAGE_SIZE this isn't needed at all anyway since those mappings are aligned to
at least their size in physical address space anyway and the logical address
shouldn't matter for the driver.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-05-28 19:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 20:12 [PATCH 00/24] hpsa updates for May 2010 Stephen M. Cameron
2010-05-27 20:12 ` [PATCH 01/24] hpsa: save pdev pointer in per hba structure early to avoid passing it around so much Stephen M. Cameron
2010-05-27 20:12 ` [PATCH 02/24] hpsa: factor out hpsa_lookup_board_id Stephen M. Cameron
2010-05-27 20:12 ` [PATCH 03/24] hpsa: factor out hpsa_board_disabled Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 04/24] hpsa: remove redundant board_id parameter from hpsa_interrupt_mode Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 05/24] hpsa: factor out hpsa_find_memory_BAR Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 06/24] hpsa: factor out hpsa_wait_for_board_ready Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 07/24] hpsa: factor out hpsa_find_cfgtables Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 08/24] hpsa: fix leak of ioremapped memory Stephen M. Cameron
2010-05-28 19:12 ` Rolf Eike Beer [this message]
2010-06-01 12:55 ` scameron
2010-05-27 20:13 ` [PATCH 09/24] hpsa: hpsa factor out hpsa_find_board_params Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 10/24] hpsa: factor out hpsa-CISS-signature-present Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 11/24] hpsa: factor out hpsa_enable_scsi_prefetch Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 12/24] hpsa: factor out hpsa_p600_dma_prefetch_quirk Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 13/24] hpsa: factor out hpsa_enter_simple_mode Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 14/24] hpsa: check that simple mode is supported Stephen M. Cameron
2010-05-27 20:13 ` [PATCH 15/24] hpsa: clean up debug ifdefs Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 16/24] hpsa: mark hpsa_mark_hpsa_put_ctlr_into_performant_mode as __devinit Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 17/24] hpsa: factor out hpsa_wait_for_mode_change_ack Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 18/24] hpsa: remove unused variable trans_offset Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 19/24] hpsa: factor out hpsa_enter_performant_mode Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 20/24] hpsa: remove unused firm_ver member of the per-hba structure Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 21/24] hpsa: Add hpsa.txt to Documentation/scsi Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 22/24] hpsa: expose controller firmware revision via /sys Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 23/24] hpsa: fix block fetch table problem Stephen M. Cameron
2010-05-27 20:14 ` [PATCH 24/24] hpsa: add entry to MAINTAINERS Stephen M. Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005282112.24802.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dab@hp.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).