From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] block: push down BKL into .locked_ioctl Date: Wed, 2 Jun 2010 06:16:21 -0400 Message-ID: <20100602101621.GA8845@infradead.org> References: <1275428028-10901-1-git-send-email-arnd@arndb.de> <20100601213755.GA1004@infradead.org> <201006020043.12257.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <201006020043.12257.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Christoph Hellwig , Jens Axboe , Vivek Goyal , Tejun Heo , Frederic Weisbecker , FUJITA Tomonori , "Martin K. Petersen" , Steven Rostedt , Douglas Gilbert , Ingo Molnar , John Kacur , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org > Ok, here comes the first step. Can you be more specific > about what you mean with the open and release methods? > Do you mean the sg.c and bsg.c chrdev file operations? No, the open and release methods in struct block_device_operations. After this the driver API for block devices is BKL free, which is an important step. To get there the locking in blkdev_get/put needs to be sorted out first, though. The ioctl pushdown patch looks good to me, btw.