From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
hch@lst.de, axboe@kernel.dk, dm-devel@redhat.com,
James.Bottomley@suse.de, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, akpm@linux-foundation.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] block: fix leaks associated with discard request payload
Date: Sun, 27 Jun 2010 17:35:45 +0200 [thread overview]
Message-ID: <20100627153545.GC25667@lst.de> (raw)
In-Reply-To: <20100627141638.GD3970@redhat.com>
On Sun, Jun 27, 2010 at 10:16:40AM -0400, Mike Snitzer wrote:
> My leak fixes have been tested extensively against all permuations of
> devices with discards (ATA trim, SCSI UNMAP, SCSI WRTIE SAME w/ unmap=1).
>
> I think we need to get Christoph's discard payload transformation
> complete by fixing the leaks _without_ trying to rework how discard
> commands are tagged, etc. E.g. fix what Jens already has staged in
> linux-2.6-block's 'for-next' and 'for-2.6.36'.
>
> With that sorted out we can then look at longer term changes to cleanup
> discard request processing.
I tend to agree. I'll look into getting rid of treating discards as
BLOCK_PC commands ontop of you patchset.
next prev parent reply other threads:[~2010-06-27 15:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100627174721D.fujita.tomonori@lab.ntt.co.jp>
[not found] ` <20100627092652.GA11625@lst.de>
[not found] ` <20100627185927K.fujita.tomonori@lab.ntt.co.jp>
2010-06-27 10:35 ` [PATCH 1/2] block: fix leaks associated with discard request payload FUJITA Tomonori
2010-06-27 11:07 ` Christoph Hellwig
2010-06-27 12:32 ` FUJITA Tomonori
2010-06-27 14:16 ` Mike Snitzer
2010-06-27 15:35 ` Christoph Hellwig [this message]
2010-06-27 16:23 ` FUJITA Tomonori
2010-06-27 15:33 ` Christoph Hellwig
2010-06-28 7:57 ` Christoph Hellwig
2010-06-28 8:14 ` FUJITA Tomonori
2010-06-28 8:18 ` Jens Axboe
2010-06-28 8:45 ` FUJITA Tomonori
2010-06-28 15:25 ` Christoph Hellwig
2010-06-30 11:55 ` FUJITA Tomonori
2010-07-01 4:21 ` FUJITA Tomonori
[not found] <20100622180029.GA15950@redhat.com>
[not found] ` <1277582211-10725-1-git-send-email-snitzer@redhat.com>
2010-06-27 15:29 ` James Bottomley
2010-06-28 17:16 ` Martin K. Petersen
2010-06-29 8:00 ` Boaz Harrosh
2010-06-29 22:28 ` [dm-devel] " Mikulas Patocka
2010-06-29 23:03 ` James Bottomley
2010-06-29 23:51 ` Mike Snitzer
2010-06-30 0:11 ` [dm-devel] " Mikulas Patocka
2010-06-30 14:22 ` James Bottomley
2010-06-30 15:36 ` Mike Snitzer
2010-06-30 16:26 ` James Bottomley
2010-07-01 12:28 ` [dm-devel] " Mikulas Patocka
2010-07-01 12:46 ` Mike Snitzer
2010-07-01 14:03 ` Mikulas Patocka
2010-06-30 8:32 ` Boaz Harrosh
2010-06-30 8:42 ` Christoph Hellwig
2010-06-30 10:25 ` Boaz Harrosh
2010-06-30 10:41 ` Christoph Hellwig
2010-06-30 10:57 ` Boaz Harrosh
2010-06-30 12:18 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100627153545.GC25667@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox