linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	jaxboe@fusionio.com, James.Bottomley@suse.de,
	linux-scsi@vger.kernel.org, hch@lst.de, dm-devel@redhat.com
Subject: Re: [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path (was: Re: scsi: unify the error handling of the prep functions)
Date: Wed, 7 Jul 2010 21:44:31 +0200	[thread overview]
Message-ID: <20100707194431.GA20206@lst.de> (raw)
In-Reply-To: <20100706135958.GA10772@redhat.com>

> Here is a minimalist patch that 1) removes the discard request's page
> leak 2) preserves the prep cleanup rules covered above.  Fixing the leak
> is a priority, introducing additional error path code sharing/cleanup is
> secondary and can come later.

I much prefer this approach.

> Signed-off-by: Mike Snitzer <snitzer@redhat.com>


Reviewed-by: Christoph Hellwig <hch@lst.de>



  reply	other threads:[~2010-07-07 19:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05  4:00 [PATCH] scsi: unify the error handling of the prep functions FUJITA Tomonori
2010-07-05 13:45 ` Mike Snitzer
2010-07-06 13:59   ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path (was: Re: scsi: unify the error handling of the prep functions) Mike Snitzer
2010-07-07 19:44     ` Christoph Hellwig [this message]
2010-07-07 19:46       ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path Jens Axboe
2010-07-08  4:17     ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path (was: Re: scsi: unify the error handling of the prep functions) FUJITA Tomonori
2010-07-08 12:06       ` Mike Snitzer
2010-07-08 12:10         ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100707194431.GA20206@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jaxboe@fusionio.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).