From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Subject: Re: [PATCH] scsi: dpt_i2o: fix memory leak Date: Wed, 14 Jul 2010 23:05:38 +0400 Message-ID: <20100714190538.GA4616@albatros> References: <1279130008-9934-1-git-send-email-segooon@gmail.com> <20100714185831.GA5164@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:45256 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754814Ab0GNTGl (ORCPT ); Wed, 14 Jul 2010 15:06:41 -0400 Content-Disposition: inline In-Reply-To: <20100714185831.GA5164@bicker> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter , kernel-janitors@vger.kernel.org, Adaptec OEM Raid Solutions , "James E.J. Bottomley" Julia Lawall On Wed, Jul 14, 2010 at 20:58 +0200, Dan Carpenter wrote: > On Wed, Jul 14, 2010 at 09:53:27PM +0400, Kulikov Vasiliy wrote: > > Free allocated memory if adpt_ioctl_to_context() failed. > > > > Signed-off-by: Kulikov Vasiliy > > --- > > drivers/scsi/dpt_i2o.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c > > index f2d4df1..dd9a43b 100644 > > --- a/drivers/scsi/dpt_i2o.c > > +++ b/drivers/scsi/dpt_i2o.c > > @@ -1839,8 +1839,10 @@ static int adpt_i2o_passthru(adpt_hba* pHba, u32 __user *arg) > > sg_offset = (msg[0]>>4)&0xf; > > msg[2] = 0x40000000; // IOCTL context > > msg[3] = adpt_ioctl_to_context(pHba, reply); > > This patch is wrong I'm afraid. adpt_ioctl_to_context() frees "reply" if > there is an error. Hmm right, but it is very strange coding style - function frees resources that it did not allocated on error and does not free them on success. Please, ignore this patch. Sorry for the noise.