linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jayamohan Kalickal" <jayamohank@serverengines.com>
To: Randy Dunlap <randy.dunlap@oracle.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	scsi <linux-scsi@vger.kernel.org>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	jejbscsi <james.bottomley@suse.de>
Subject: Re: [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT_SYSFS
Date: Thu, 29 Jul 2010 14:06:33 -0700	[thread overview]
Message-ID: <20100729210633.19ce36e7@mailhost.serverengines.com> (raw)
In-Reply-To: 20100729101609.965dbe48.randy.dunlap@oracle.com

_____  
From: Randy Dunlap [mailto:randy.dunlap@oracle.com]
To: Stephen Rothwell [mailto:sfr@canb.auug.org.au], scsi [mailto:linux-scsi@vger.kernel.org], Jayamohan Kallickal [mailto:jayamohank@serverengines.com]
Cc: linux-next@vger.kernel.org, LKML [mailto:linux-kernel@vger.kernel.org], jejbscsi [mailto:james.bottomley@suse.de]
Sent: Thu, 29 Jul 2010 10:16:09 -0700
Subject: [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT_SYSFS

From: Randy Dunlap <randy.dunlap@oracle.com>

be2iscsi uses iscsi_boot_*() interfaces, so it should ensure that
ISCSI_BOOT_SYSFS is enabled.

ERROR: "iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
ERROR: "iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
ERROR: "iscsi_boot_create_host_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
ERROR: "iscsi_boot_create_initiator" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!
ERROR: "iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


Acked-by: Jayamohan Kallickal <jayamohank@serverengines.com> 
---
 drivers/scsi/be2iscsi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100729.orig/drivers/scsi/be2iscsi/Kconfig
+++ linux-next-20100729/drivers/scsi/be2iscsi/Kconfig
@@ -2,6 +2,7 @@ config BE2ISCSI
 	tristate "ServerEngines' 10Gbps iSCSI - BladeEngine 2"
 	depends on PCI && SCSI && NET
 	select SCSI_ISCSI_ATTRS
+	select ISCSI_BOOT_SYSFS
 
 	help
 	This driver implements the iSCSI functionality for ServerEngines'
---

___________________________________________________________________________________
This message, together with any attachment(s), contains confidential and proprietary information of
ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized
review, printing, retention, copying, disclosure or distribution is strictly prohibited.  If you are not the
intended recipient of this message, please immediately advise the sender by reply email message and
delete all copies of this message and any attachment(s). Thank you.

             reply	other threads:[~2010-07-29 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 21:06 Jayamohan Kalickal [this message]
     [not found] <20100729143211.9e7edaed.sfr@canb.auug.org.au>
2010-07-29 17:16 ` [PATCH -next] scsi: be2iscsi needs ISCSI_BOOT_SYSFS Randy Dunlap
2010-07-29 19:34   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100729210633.19ce36e7@mailhost.serverengines.com \
    --to=jayamohank@serverengines.com \
    --cc=james.bottomley@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).