From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] qla4xxx: initialize some variables for gcc Date: Fri, 13 Aug 2010 23:03:50 +0200 Message-ID: <20100813210350.GT645@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Ravi Anand Cc: Vikas Chaudhary , iscsi-driver@qlogic.com, "James E.J. Bottomley" , Karen Higgins , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Gcc complains because these variables aren't initialized. drivers/scsi/qla4xxx/ql4_nx.c: In function =E2=80=98qla4_8xxx_get_flash= _info=E2=80=99: drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: =E2=80=98fid=E2=80=99 may = be used uninitialized in this function drivers/scsi/qla4xxx/ql4_nx.c:1952: note: =E2=80=98fid=E2=80=99 was dec= lared here drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: =E2=80=98mid=E2=80=99 may = be used uninitialized in this function drivers/scsi/qla4xxx/ql4_nx.c:1952: note: =E2=80=98mid=E2=80=99 was dec= lared here It's not a big deal. We only print the uninitialized value on error paths when debugging is enabled. Still it's nice to clean it up and to stop gcc from grumbling. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_n= x.c index 3e119ae..e443fa6 100644 --- a/drivers/scsi/qla4xxx/ql4_nx.c +++ b/drivers/scsi/qla4xxx/ql4_nx.c @@ -1949,7 +1949,8 @@ qla4_8xxx_get_fdt_info(struct scsi_qla_host *ha) uint16_t cnt, chksum; uint16_t *wptr; struct qla_fdt_layout *fdt; - uint16_t mid, fid; + uint16_t mid =3D -1; + uint16_t fid =3D -1; struct ql82xx_hw_data *hw =3D &ha->hw; =20 hw->flash_conf_off =3D FARX_ACCESS_FLASH_CONF;