linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: linux-scsi@vger.kernel.org
Subject: odd debug spew while reading a CD.
Date: Tue, 17 Aug 2010 17:08:58 -0400	[thread overview]
Message-ID: <20100817210858.GA30880@redhat.com> (raw)

When ripping an audio CD earlier, I got a bunch of these messages in dmesg,
even though the CD read just fine..

[ 8669.821077] sr 4:0:0:0: [sr0] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
[ 8669.821083] sr 4:0:0:0: [sr0] Sense Key : Illegal Request [current] 
[ 8669.821090] ILI
[ 8669.821093] sr 4:0:0:0: [sr0] Add. Sense: Illegal mode for this track
[ 8669.821101] sr 4:0:0:0: [sr0] CDB: Read(10): 28 00 00 00 00 00 00 00 02 00
[ 8669.821116] end_request: I/O error, dev sr0, sector 0
[ 8669.821121] Buffer I/O error on device sr0, logical block 0
[ 8669.821128] Buffer I/O error on device sr0, logical block 1

the "ILI" message on its own caught my eye.
In constants.c, we print a prefix before that message in this case..

1345                 if (fixed_valid)
1346                         res += snprintf(buff + res, blen - res,
1347                                         "Info fld=0x%x", info);

But if fixed_valid (sense_buffer[0] & 0x80;) is not true, we end up printing
status codes with no prefix, which looks odd.  Is this the desired behaviour ?

	Dave


                 reply	other threads:[~2010-08-17 21:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817210858.GA30880@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).