* [PATCH 2/2] scsi: fix kconfig dependency warnings
@ 2010-08-17 18:36 Randy Dunlap
2010-08-18 14:28 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-08-17 18:36 UTC (permalink / raw)
To: scsi; +Cc: jejbscsi, Ralf Baechle
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig dependency warnings in scsi/Kconfig:
warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
drivers/scsi/Kconfig | 3 ++-
drivers/scsi/libsas/Kconfig | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
--- linux-next-20100810.orig/drivers/scsi/libsas/Kconfig
+++ linux-next-20100810/drivers/scsi/libsas/Kconfig
@@ -26,6 +26,7 @@ config SCSI_SAS_LIBSAS
tristate "SAS Domain Transport Attributes"
depends on SCSI
select SCSI_SAS_ATTRS
+ select BLK_DEV_BSG
help
This provides transport specific helpers for SAS drivers which
use the domain device construct (like the aic94xxx).
--- linux-next-20100810.orig/drivers/scsi/Kconfig
+++ linux-next-20100810/drivers/scsi/Kconfig
@@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
config SCSI_SAS_ATTRS
tristate "SAS Transport Attributes"
- depends on SCSI && BLK_DEV_BSG
+ depends on SCSI
+ select BLK_DEV_BSG
help
If you wish to export transport-specific information about
each attached SAS device to sysfs, say Y.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] scsi: fix kconfig dependency warnings
2010-08-17 18:36 [PATCH 2/2] scsi: fix kconfig dependency warnings Randy Dunlap
@ 2010-08-18 14:28 ` James Bottomley
2010-08-18 16:28 ` [PATCH 2/2 v2] " Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2010-08-18 14:28 UTC (permalink / raw)
To: Randy Dunlap; +Cc: scsi, Ralf Baechle
On Tue, 2010-08-17 at 11:36 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kconfig dependency warnings in scsi/Kconfig:
>
> warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> ---
> drivers/scsi/Kconfig | 3 ++-
> drivers/scsi/libsas/Kconfig | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-next-20100810.orig/drivers/scsi/libsas/Kconfig
> +++ linux-next-20100810/drivers/scsi/libsas/Kconfig
> @@ -26,6 +26,7 @@ config SCSI_SAS_LIBSAS
> tristate "SAS Domain Transport Attributes"
> depends on SCSI
> select SCSI_SAS_ATTRS
> + select BLK_DEV_BSG
This isn't right if you do the below.
Selects cascade.
> help
> This provides transport specific helpers for SAS drivers which
> use the domain device construct (like the aic94xxx).
> --- linux-next-20100810.orig/drivers/scsi/Kconfig
> +++ linux-next-20100810/drivers/scsi/Kconfig
> @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
>
> config SCSI_SAS_ATTRS
> tristate "SAS Transport Attributes"
> - depends on SCSI && BLK_DEV_BSG
> + depends on SCSI
> + select BLK_DEV_BSG
So this is the only part that's necessary, isn't it? Could you resubmit
with just this?
Thanks,
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2 v2] scsi: fix kconfig dependency warnings
2010-08-18 14:28 ` James Bottomley
@ 2010-08-18 16:28 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2010-08-18 16:28 UTC (permalink / raw)
To: James Bottomley; +Cc: scsi, Ralf Baechle
Thanks for your comments.
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig dependency warnings in scsi/Kconfig:
warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG)
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
---
drivers/scsi/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20100817.orig/drivers/scsi/Kconfig
+++ linux-next-20100817/drivers/scsi/Kconfig
@@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
config SCSI_SAS_ATTRS
tristate "SAS Transport Attributes"
- depends on SCSI && BLK_DEV_BSG
+ depends on SCSI
+ select BLK_DEV_BSG
help
If you wish to export transport-specific information about
each attached SAS device to sysfs, say Y.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-18 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-17 18:36 [PATCH 2/2] scsi: fix kconfig dependency warnings Randy Dunlap
2010-08-18 14:28 ` James Bottomley
2010-08-18 16:28 ` [PATCH 2/2 v2] " Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).