From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
James Bottomley <James.Bottomley@suse.de>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi@vger.kernel.org
Subject: Re: scsi_dh_alua: add missing transitioning state support
Date: Tue, 31 Aug 2010 11:11:29 -0400 [thread overview]
Message-ID: <20100831151129.GA18855@redhat.com> (raw)
In-Reply-To: <4C7B7B9E.3020002@suse.de>
On Mon, Aug 30 2010 at 5:36am -0400,
Hannes Reinecke <hare@suse.de> wrote:
> Nicholas A. Bellinger wrote:
> > On Tue, 2010-08-17 at 15:05 -0400, Mike Snitzer wrote:
> >> Handle transitioning in the prep_fn.
> >> Handle transitioning in alua_rtpg's implicit alua code too.
> >>
> >> These gaps were identified during controller failover testing of an
> >> ALUA array.
> >>
> >> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> >> ---
> >> drivers/scsi/device_handler/scsi_dh_alua.c | 10 +++++++---
> >> 1 files changed, 7 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> >> index 1a970a7..c1eedc5 100644
> >> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> >> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> >> @@ -616,6 +616,9 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_dh_data *h)
> >> h->state == TPGS_STATE_STANDBY)
> >> /* Useable path if active */
> >> err = SCSI_DH_OK;
> >> + else if (h->state == TPGS_STATE_TRANSITIONING)
> >> + /* State transition, retry */
> >> + goto retry;
> >> else
> >> /* Path unuseable for unavailable/offline */
> >> err = SCSI_DH_DEV_OFFLINED;
> >> @@ -698,13 +701,14 @@ static int alua_prep_fn(struct scsi_device *sdev, struct request *req)
> >> struct alua_dh_data *h = get_alua_data(sdev);
> >> int ret = BLKPREP_OK;
> >>
> >> - if (h->state != TPGS_STATE_OPTIMIZED &&
> >> - h->state != TPGS_STATE_NONOPTIMIZED) {
> >> + if (h->state == TPGS_STATE_TRANSITIONING)
> >> + ret = BLKPREP_DEFER;
> >> + else if (h->state != TPGS_STATE_OPTIMIZED &&
> >> + h->state != TPGS_STATE_NONOPTIMIZED) {
> >> ret = BLKPREP_KILL;
> >> req->cmd_flags |= REQ_QUIET;
> >> }
> >> return ret;
> >> -
> >> }
> >>
> >
> > Makes sense to me..
> >
> > Acked-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> >
> Not so fast. There are two problems with this approach:
>
> The path is retried indefinitely. Arrays are _supposed_ to be in 'transitioning'
> only temporary; however, if the array is stuck due to a fw error we're stuck in 'defer',
> too.
And what is the problem with that? The IO will eventually time out.
> Secondly this path fails with 'directio' multipath checker. Remember that 'directio'
> is using 'fs' requests, not block-pc ones. Hence for all I/O the prep_fn() callback
> is evaluated, which will return 'DEFER' here once the path is in transitioning.
> And the state is never updated as RTPG is never called.
Testing ALUA with directio path checker did not result in such immutable
state in the few instances that TPGS_STATE_TRANSITIONING was seen in
alua_prep_fn.
> I'm currently preparing a patch which addressed these situations, too.
OK, please share.
Thanks,
Mike
next prev parent reply other threads:[~2010-08-31 15:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 19:05 [PATCH] scsi_dh_alua: add missing transitioning state support Mike Snitzer
2010-08-17 19:23 ` Nicholas A. Bellinger
2010-08-30 9:36 ` Hannes Reinecke
2010-08-31 15:11 ` Mike Snitzer [this message]
2010-09-20 15:35 ` Mike Snitzer
2010-09-21 2:27 ` Mike Christie
2010-09-21 2:28 ` Mike Christie
2010-09-21 19:33 ` Mike Snitzer
2010-09-21 21:14 ` Mike Christie
2010-09-22 10:13 ` Hannes Reinecke
2010-09-22 12:29 ` Mike Snitzer
2010-09-23 7:15 ` Hannes Reinecke
2010-09-23 13:44 ` Mike Snitzer
2010-09-23 18:53 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831151129.GA18855@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).