From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: James.Bottomley@suse.de, fujita.tomonori@lab.ntt.co.jp,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG
Date: Thu, 2 Sep 2010 07:56:57 -0700 [thread overview]
Message-ID: <20100902075657.7a699c3c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4C7FBF290200007800013FB9@vpn.id2.novell.com>
On Thu, 02 Sep 2010 14:13:45 +0100 Jan Beulich wrote:
> Since SCSI_SAS_ATTRS gets selected in a few places, making it merely
> depend on the (user selectable) BLK_DEV_BSG isn't correct (as the
> result may be that the latter doesn't get enabled, which recent
> kconfig validly warns about). Convert the "depends on" to a "select".
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Fujita Tomonori <fujita.tomonori@lab.ntt.co.jp>
>
> ---
> drivers/scsi/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.36-rc3/drivers/scsi/Kconfig
> +++ 2.6.36-rc3-scsi-sas-attrs/drivers/scsi/Kconfig
> @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
>
> config SCSI_SAS_ATTRS
> tristate "SAS Transport Attributes"
> - depends on SCSI && BLK_DEV_BSG
> + depends on SCSI
> + select BLK_DEV_BSG
> help
> If you wish to export transport-specific information about
> each attached SAS device to sysfs, say Y.
>
>
>
> --
Ack if it will help.
http://marc.info/?l=linux-scsi&m=128214896025671&w=2
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2010-09-02 14:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 13:13 [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG Jan Beulich
2010-09-02 14:56 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902075657.7a699c3c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=JBeulich@novell.com \
--cc=James.Bottomley@suse.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).