* [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG
@ 2010-09-02 13:13 Jan Beulich
2010-09-02 14:56 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2010-09-02 13:13 UTC (permalink / raw)
To: James.Bottomley; +Cc: fujita.tomonori, linux-scsi
Since SCSI_SAS_ATTRS gets selected in a few places, making it merely
depend on the (user selectable) BLK_DEV_BSG isn't correct (as the
result may be that the latter doesn't get enabled, which recent
kconfig validly warns about). Convert the "depends on" to a "select".
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Fujita Tomonori <fujita.tomonori@lab.ntt.co.jp>
---
drivers/scsi/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-2.6.36-rc3/drivers/scsi/Kconfig
+++ 2.6.36-rc3-scsi-sas-attrs/drivers/scsi/Kconfig
@@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
config SCSI_SAS_ATTRS
tristate "SAS Transport Attributes"
- depends on SCSI && BLK_DEV_BSG
+ depends on SCSI
+ select BLK_DEV_BSG
help
If you wish to export transport-specific information about
each attached SAS device to sysfs, say Y.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG
2010-09-02 13:13 [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG Jan Beulich
@ 2010-09-02 14:56 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2010-09-02 14:56 UTC (permalink / raw)
To: Jan Beulich; +Cc: James.Bottomley, fujita.tomonori, linux-scsi
On Thu, 02 Sep 2010 14:13:45 +0100 Jan Beulich wrote:
> Since SCSI_SAS_ATTRS gets selected in a few places, making it merely
> depend on the (user selectable) BLK_DEV_BSG isn't correct (as the
> result may be that the latter doesn't get enabled, which recent
> kconfig validly warns about). Convert the "depends on" to a "select".
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Fujita Tomonori <fujita.tomonori@lab.ntt.co.jp>
>
> ---
> drivers/scsi/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.36-rc3/drivers/scsi/Kconfig
> +++ 2.6.36-rc3-scsi-sas-attrs/drivers/scsi/Kconfig
> @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
>
> config SCSI_SAS_ATTRS
> tristate "SAS Transport Attributes"
> - depends on SCSI && BLK_DEV_BSG
> + depends on SCSI
> + select BLK_DEV_BSG
> help
> If you wish to export transport-specific information about
> each attached SAS device to sysfs, say Y.
>
>
>
> --
Ack if it will help.
http://marc.info/?l=linux-scsi&m=128214896025671&w=2
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-02 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 13:13 [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG Jan Beulich
2010-09-02 14:56 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).