From: Christof Schmitt <christof.schmitt@de.ibm.com>
To: Anil kumar <anils_r@yahoo.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: scsi_cmnd data_buffer checksum
Date: Thu, 9 Sep 2010 11:29:06 +0200 [thread overview]
Message-ID: <20100909092906.GA21760@schmichrtp.mainz.de.ibm.com> (raw)
In-Reply-To: <215508.92384.qm@web32402.mail.mud.yahoo.com>
On Thu, Sep 09, 2010 at 02:09:28AM -0700, Anil kumar wrote:
> I quickly tried copying the data buffer to local buffers as follows:
>
> In Queuecommand:
>
> cmd->local_write_buf = pci_alloc_consistent(...);
> cmd->write_buf = (u8 *)(kmap_atomic(sg->page, KM_IRQ0) + sg->offset);
>
> memcpy(cmd->local_write_buf, cmd->write_buf, scsibufflen(scsi_cmnd));
>
> Now I calculate checksums of cmd->write_buf and my local cmd->local_write_buf
>
> and the checksum fails. Am I doing something wrong here?
Are you only copying one element of the sg list? Are you sure that
there is only one element? If not, you have to use something like
scsi_kmap_atomic_sg and create a copy of each element (maybe use
scsi_for_each_sg).
Or maybe there is another problem... hard to guess from the distance.
Christof
next prev parent reply other threads:[~2010-09-09 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 3:36 scsi_cmnd data_buffer checksum Anil kumar
2010-09-09 8:00 ` Christof Schmitt
2010-09-09 8:35 ` Anil kumar
2010-09-09 8:51 ` Christof Schmitt
2010-09-09 9:09 ` Anil kumar
2010-09-09 9:29 ` Christof Schmitt [this message]
2010-09-09 13:23 ` Martin K. Petersen
2010-09-09 19:34 ` Anil kumar
2010-09-10 3:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909092906.GA21760@schmichrtp.mainz.de.ibm.com \
--to=christof.schmitt@de.ibm.com \
--cc=anils_r@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox