From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Wilcox <willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sarah Sharp
<sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH] UAS driver
Date: Mon, 27 Sep 2010 22:56:49 -0700 [thread overview]
Message-ID: <20100928055649.GB8922@kroah.com> (raw)
In-Reply-To: <20100928050733.GB3799-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Tue, Sep 28, 2010 at 01:07:34AM -0400, Matthew Wilcox wrote:
> +static struct usb_device_id uas_usb_ids[] = {
> + { USB_INTERFACE_INFO(8, 6, 0x50) },
> + { USB_INTERFACE_INFO(8, 6, 0x62) },
> + { USB_INTERFACE_INFO(8, 6, 0xaa) }, /* A prototype */
> + { }
Don't we have the proper #defines in the usb/ch9.h file that you can use
here? If not, please add them so that we don't have "magic" numbers.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-09-28 5:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 5:07 [PATCH] UAS driver Matthew Wilcox
2010-09-28 5:55 ` Greg KH
[not found] ` <20100928050733.GB3799-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 5:56 ` Greg KH [this message]
2010-09-28 6:45 ` Matthew Wilcox
[not found] ` <20100928064549.GD3799-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 7:06 ` Greg KH
[not found] ` <20100928070613.GA11056-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-09-28 7:17 ` Matthew Wilcox
2010-09-28 7:25 ` Greg KH
2010-09-28 7:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928055649.GB8922@kroah.com \
--to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox