From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 2/2] Add UAS driver Date: Tue, 28 Sep 2010 11:11:34 -0700 Message-ID: <20100928181134.GA17657@kroah.com> References: <1285668896-6356-1-git-send-email-willy@linux.intel.com> <1285668896-6356-2-git-send-email-willy@linux.intel.com> <20100928175122.GE25677@one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from kroah.org ([198.145.64.141]:50208 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755737Ab0I1SPc (ORCPT ); Tue, 28 Sep 2010 14:15:32 -0400 Content-Disposition: inline In-Reply-To: <20100928175122.GE25677@one-eyed-alien.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Matthew Wilcox , linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, sarah.a.sharp@linux.intel.com, Matthew Wilcox On Tue, Sep 28, 2010 at 10:51:22AM -0700, Matthew Dharm wrote: > On Tue, Sep 28, 2010 at 06:14:56AM -0400, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > USB Attached SCSI is a new protocol specified jointly by the SCSI T10 > > committee and the USB Implementors Forum. > > > > Signed-off-by: Matthew Wilcox > > --- > > MAINTAINERS | 8 + > > drivers/usb/storage/Kconfig | 13 + > > drivers/usb/storage/Makefile | 1 + > > drivers/usb/storage/uas.c | 751 ++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 773 insertions(+), 0 deletions(-) > > create mode 100644 drivers/usb/storage/uas.c > > Given that this is distinctly not usb-storage, and it is entirely contained > within a single file, does it really belong in the drivers/usb/storage > directory? > > That just seems like a plan for confusion. The fact that there is a big > "this is not usb-storage" message in the comments of uas.c would seem to > support this position. > > Given that it is a single file, I would put it in drivers/usb directly. If > you wanted your own directory for possible future refactoring into multiple > files or addid other files (like usb-storage did to support oddball > devices), then maybe create a drivers/usb/uas directory. What about drivers/usb/class/ where a number of other USB class drivers live. That would make more sense, right? thanks, greg k-h