From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Oliver Neukum <oliver@neukum.org>,
greg@kroah.com, linux-usb@vger.kernel.org,
linux-scsi@vger.kernel.org,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH 2/2] Add UAS driver
Date: Wed, 29 Sep 2010 00:47:29 -0400 [thread overview]
Message-ID: <20100929044729.GA4967@xanatos> (raw)
In-Reply-To: <20100929005413.GB4689@linux.intel.com>
On Tue, Sep 28, 2010 at 08:54:13PM -0400, Matthew Wilcox wrote:
>
> [Could you trim a little when replying?]
>
> On Tue, Sep 28, 2010 at 03:13:53PM +0200, Oliver Neukum wrote:
> > Am Dienstag, 28. September 2010, 12:14:56 schrieb Matthew Wilcox:
> > > + usb_free_streams(intf, eps, 3, GFP_KERNEL);
> >
> > This implies that this can fail due to a lack of memory.
> > Then what?
>
> Uhh. I think I'll have to get Sarah to answer that question. We probably
> end up resetting the endpoints instead of telling the endpoint to stop
> doing streams.
Sorry Oliver, the usb_free_streams() calls into the xHCI driver, which
doesn't actually do anything with the memory flags. Alan Stern already
noted it should be removed. Freeing streams doesn't rely on memory
allocation (a command is pre-allocated when streams are enabled, and a
TRB is reserved on the command ring).
Sarah Sharp
next prev parent reply other threads:[~2010-09-29 4:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:14 [PATCH 1/2] Move USB Storage definitions to their own header file Matthew Wilcox
2010-09-28 10:14 ` [PATCH 2/2] Add UAS driver Matthew Wilcox
[not found] ` <1285668896-6356-2-git-send-email-willy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-28 13:13 ` Oliver Neukum
2010-09-29 0:54 ` Matthew Wilcox
2010-09-29 4:47 ` Sarah Sharp [this message]
[not found] ` <20100929005413.GB4689-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2010-09-29 20:20 ` Oliver Neukum
2010-09-30 6:04 ` Rolf Eike Beer
2010-09-28 13:41 ` David Vrabel
2010-09-29 0:55 ` Matthew Wilcox
2010-09-29 3:30 ` David Brownell
2010-09-28 17:51 ` Matthew Dharm
2010-09-28 18:11 ` Greg KH
2010-09-28 18:52 ` Matthew Dharm
2010-09-29 1:56 ` Greg KH
[not found] ` <20100928175122.GE25677-JGfshJpz5UybPZpvUQj5UqxOck334EZe@public.gmane.org>
2010-09-29 1:01 ` Matthew Wilcox
2010-09-29 2:08 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929044729.GA4967@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=oliver@neukum.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox