From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
James Bottomley <James.Bottomley@suse.de>,
Jens Axboe <axboe@kernel.dk>, Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [RFCv3 00/21] TCM Core and TCM_Loop patches for v2.6.37
Date: Mon, 8 Nov 2010 09:39:52 -0500 [thread overview]
Message-ID: <20101108143952.GB22121@infradead.org> (raw)
In-Reply-To: <1287441313-19703-1-git-send-email-nab@linux-iscsi.org>
Some comments on the configfs to backend API:
- the various get_*_info methods look like they really should use
the seq_file API. That gives you safety against overflows,
and simplifies the code.
- why are show_configfs_dev_params and get_dev_info separate
methods if they always end up calling the same code?
- the set_configfs_dev_params method implementation contains some
rather nast parsing code. They look like they really should use
the parser.h helpers we use for mount option parsing.
next prev parent reply other threads:[~2010-11-08 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 22:35 [RFCv3 00/21] TCM Core and TCM_Loop patches for v2.6.37 Nicholas A. Bellinger
2010-11-08 14:33 ` Christoph Hellwig
2010-11-08 14:50 ` FUJITA Tomonori
2010-11-08 15:08 ` Christoph Hellwig
2010-11-08 21:10 ` Nicholas A. Bellinger
2010-11-08 14:39 ` Christoph Hellwig [this message]
2010-11-08 21:20 ` Nicholas A. Bellinger
2010-11-08 21:48 ` Christoph Hellwig
2010-11-08 22:04 ` Nicholas A. Bellinger
2010-11-08 22:37 ` Christoph Hellwig
2010-11-08 18:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108143952.GB22121@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@suse.de \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox