From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Luben Tuikov <ltuikov@yahoo.com>,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [USB] UAS: eliminate infinite loop; add debug print
Date: Mon, 8 Nov 2010 07:55:36 -0800 [thread overview]
Message-ID: <20101108155536.GD10092@kroah.com> (raw)
In-Reply-To: <20101108112456.GI4173@linux.intel.com>
On Mon, Nov 08, 2010 at 06:24:56AM -0500, Matthew Wilcox wrote:
> On Fri, Oct 29, 2010 at 05:33:19PM -0700, Luben Tuikov wrote:
> > Eliminate an infinite loop whereby the SCSI layer
> > would reissue a command (which would be failed by
> > the driver) ad infinitum. (Invariably due to the
> > driver's profuse use of the
> > SCSI_MLQUEUE_DEVICE_BUSY returned result in its
> > queuecommand() method.)
> >
> > Also add a debug option and a few debug prints.
>
> Why have you added your own debug scheme instead of using dev_dbg?
I agree, don't ever do that.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-08 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 0:33 [PATCH] [USB] UAS: eliminate infinite loop; add debug print Luben Tuikov
2010-11-03 16:24 ` Greg KH
2010-11-08 11:24 ` Matthew Wilcox
2010-11-08 15:55 ` Greg KH [this message]
2010-11-08 17:27 ` Luben Tuikov
[not found] ` <272723.33242.qm-5Es2LHxk9sSvuULXzWHTWIglqE1Y4D90QQ4Iyu8u01E@public.gmane.org>
2010-11-08 17:38 ` Greg KH
2010-11-08 17:57 ` Luben Tuikov
2010-11-08 17:40 ` Michał Nazarewicz
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 10:51 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108155536.GD10092@kroah.com \
--to=greg@kroah.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).