From: Christoph Hellwig <hch@infradead.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] tcm: Convert backstore ->set_configfs_dev_params() to use parser.h
Date: Tue, 9 Nov 2010 05:03:59 -0500 [thread overview]
Message-ID: <20101109100359.GA26324@infradead.org> (raw)
In-Reply-To: <1289296122-13152-1-git-send-email-nab@linux-iscsi.org>
> + opts = kstrdup(page, GFP_KERNEL);
What do you need the this copy for?
Otherwise looks good.
next prev parent reply other threads:[~2010-11-09 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 9:48 [PATCH] tcm: Convert backstore ->set_configfs_dev_params() to use parser.h Nicholas A. Bellinger
2010-11-09 10:03 ` Christoph Hellwig [this message]
2010-11-09 10:03 ` Nicholas A. Bellinger
2010-11-09 13:45 ` Christoph Hellwig
2010-11-09 17:58 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109100359.GA26324@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox